Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(anta.tests): Cleaning up flow-tracking tests module #964

Merged
merged 11 commits into from
Jan 28, 2025
Merged

fix(anta.tests): Cleaning up flow-tracking tests module #964

merged 11 commits into from
Jan 28, 2025
+185 −198

Conversation

vitthalmagadum
Copy link
Collaborator

Description

Refactoring flow-tracking tests module to address the following issues:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 12, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #964 will not alter performance

Comparing vitthalmagadum:feat/flow_tracking (ae0bb49) with main (164b736)

Summary

✅ 22 untouched benchmarks

@vitthalmagadum vitthalmagadum mentioned this pull request Dec 12, 2024
Open
32 tasks
@gmuloc gmuloc added this to the v1.3.0 milestone Dec 24, 2024
@gmuloc gmuloc self-requested a review January 14, 2025 13:03
gmuloc
gmuloc requested changes Jan 14, 2025
View reviewed changes
anta/tests/flow_tracking.py Outdated Show resolved Hide resolved
anta/tests/flow_tracking.py Outdated Show resolved Hide resolved
anta/tests/flow_tracking.py Outdated Show resolved Hide resolved
anta/tests/flow_tracking.py Outdated Show resolved Hide resolved
anta/tests/flow_tracking.py Outdated Show resolved Hide resolved
anta/tests/flow_tracking.py Outdated Show resolved Hide resolved
anta/tests/flow_tracking.py Outdated Show resolved Hide resolved
anta/tests/flow_tracking.py Outdated Show resolved Hide resolved
anta/tests/flow_tracking.py Outdated Show resolved Hide resolved
anta/input_models/flow_tracking.py Outdated Show resolved Hide resolved
@vitthalmagadum vitthalmagadum requested a review from gmuloc January 15, 2025 10:01
gmuloc
gmuloc requested changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move back revision to 1

@vitthalmagadum
Copy link
Collaborator Author

please move back revision to 1

Reverted to revision 1.
Thanks!!

@vitthalmagadum vitthalmagadum requested a review from gmuloc January 15, 2025 16:33
gmuloc
gmuloc requested changes Jan 21, 2025
View reviewed changes
anta/tests/flow_tracking.py Outdated Show resolved Hide resolved
anta/tests/flow_tracking.py Outdated Show resolved Hide resolved
anta/tests/flow_tracking.py Outdated Show resolved Hide resolved
gmuloc
gmuloc reviewed Jan 28, 2025
View reviewed changes
anta/tests/flow_tracking.py Outdated Show resolved Hide resolved
gmuloc
gmuloc approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once CI succeeds

gmuloc
gmuloc approved these changes Jan 28, 2025
View reviewed changes
anta/tests/flow_tracking.py Outdated Show resolved Hide resolved
anta/tests/flow_tracking.py Outdated Show resolved Hide resolved
anta/tests/flow_tracking.py Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@gmuloc gmuloc merged commit 461fa69 into aristanetworks:main Jan 28, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@carl-baillargeon carl-baillargeon Awaiting requested review from carl-baillargeon

Assignees

@vitthalmagadum vitthalmagadum

Labels
rn: fix(anta.tests)
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vitthalmagadum @gmuloc