Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_designs): Remove dependency on overlay_routing_protocol and evpn_role for WAN routers #4865

Open
wants to merge 38 commits into
base: devel
Choose a base branch
from
+2,177 −338
Open

Refactor(eos_designs): Remove dependency on overlay_routing_protocol and evpn_role for WAN routers #4865

Show file tree
Hide file tree
Changes from 27 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
f7ffd86
Refactor(eos_designs): Remove dependency on overlay_routing_protocol …
gmuloc Jan 7, 2025
23e19d5
Test: Moleculing the molecule
gmuloc Jan 9, 2025
51dba69
Merge branch 'devel' into relax-wan-default-requirements
gmuloc Jan 14, 2025
597bf79
feat: Adjust evpn_role and overlay_routing_protocol defaults when tog…
gmuloc Jan 14, 2025
ed2dcd2
Refactor: Address PR comment
gmuloc Jan 14, 2025
4d1565e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 14, 2025
f1ce417
Doc: Add TODO for our future-selves, they shall thank this
gmuloc Jan 14, 2025
d4808be
Merge branch 'devel' into relax-wan-default-requirements
gmuloc Jan 15, 2025
db3656a
Refactor: Documentation cleaning
gmuloc Jan 15, 2025
57455cf
Test: WIP add molecule for EVPN on LAN
gmuloc Jan 15, 2025
bc10746
Merge branch 'devel' into relax-wan-default-requirements
gmuloc Jan 15, 2025
8e85870
Merge branch 'devel' into relax-wan-default-requirements
gmuloc Jan 20, 2025
b2a7447
Refactor(eos_designs): Make the knob preview
gmuloc Jan 20, 2025
bc86956
Test: Fixing typos in molecule
gmuloc Jan 20, 2025
d13f8a3
Fix(eos_designs): Logical error
gmuloc Jan 20, 2025
c3e1490
Merge branch 'devel' into relax-wan-default-requirements
gmuloc Jan 21, 2025
33b2dd7
Test: Moleculing the molecule
gmuloc Jan 21, 2025
103da3b
Merge branch 'devel' into relax-wan-default-requirements
gmuloc Jan 23, 2025
6e76420
Merge branch 'devel' into relax-wan-default-requirements
gmuloc Jan 23, 2025
5f9716d
Refactor: Address schema comment
gmuloc Jan 23, 2025
db86cab
Refactor: Address some PR comments
gmuloc Jan 23, 2025
e462d9c
Refactor: Block the 3 target keys in shared utils for WAN routers
gmuloc Jan 24, 2025
6ae4f85
Refactor: Change shared_utils vrf_wan_vni
gmuloc Jan 24, 2025
41ca88b
Refactor: Remove ties to overlay_address_families for WAN
gmuloc Jan 24, 2025
5a33098
Merge branch 'devel' into relax-wan-default-requirements
gmuloc Jan 27, 2025
272590e
Refactor: Address PR comments
gmuloc Jan 27, 2025
0b1bedc
Merge branch 'devel' into relax-wan-default-requirements
gmuloc Jan 27, 2025
453fcc6
Refactor: Fix wrong logic for VRF default
gmuloc Jan 27, 2025
81152fd
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 27, 2025
87045d9
Merge branch 'devel' into relax-wan-default-requirements
gmuloc Jan 27, 2025
5341ba1
Refactor: Sort the set for idempotency
gmuloc Jan 27, 2025
9cd0a43
Test: Change test input after refactoring
gmuloc Jan 27, 2025
4851a13
WIP
gmuloc Jan 28, 2025
6e71074
is_wan_vrf
ClausHolbechArista Jan 28, 2025
c43d625
Update python-avd/pyavd/_eos_designs/eos_designs_facts/overlay.py
gmuloc Jan 28, 2025
e110861
Merge branch 'devel' into relax-wan-default-requirements
gmuloc Jan 28, 2025
b910c6e
Merge branch 'devel' into relax-wan-default-requirements
gmuloc Jan 28, 2025
46d519f
Test: Add tests to validate absence of address families with and with…
gmuloc Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ansible_collections/arista/avd/examples/cv-pathfinder/intended/structured_configs/pf1.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,10 +571,10 @@ router_bgp:
route_map: RM-CONN-2-BGP
address_family_evpn:
peer_groups:
- name: WAN-RR-OVERLAY-PEERS
- name: WAN-OVERLAY-PEERS
activate: true
encapsulation: path-selection
- name: WAN-OVERLAY-PEERS
- name: WAN-RR-OVERLAY-PEERS
activate: true
encapsulation: path-selection
next_hop:
Expand Down
4 changes: 2 additions & 2 deletions ansible_collections/arista/avd/examples/cv-pathfinder/intended/structured_configs/pf2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,10 +571,10 @@ router_bgp:
route_map: RM-CONN-2-BGP
address_family_evpn:
peer_groups:
- name: WAN-RR-OVERLAY-PEERS
- name: WAN-OVERLAY-PEERS
activate: true
encapsulation: path-selection
- name: WAN-OVERLAY-PEERS
- name: WAN-RR-OVERLAY-PEERS
activate: true
encapsulation: path-selection
next_hop:
Expand Down
31 changes: 0 additions & 31 deletions ...gns_negative_unit_tests/inventory/host_vars/invalid-wan-role-overlay-routing-protocol.yml
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions ansible_collections/arista/avd/molecule/eos_designs_negative_unit_tests/inventory/hosts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,6 @@ all:
invalid-uplink-port-channel-id-3-l3leaf-1:
invalid-uplink-port-channel-id-3-l3leaf-2:
invalid-uplink-port-channel-id-3-l2leaf-2:
FABRIC_WAN_ROLE_OVERLAY_ROUTING_PROTOCOL:
hosts:
invalid-wan-role-overlay-routing-protocol:
FABRIC_P2P_VRFS:
hosts:
invalid-uplink-type-p2p-vrfs-underlay-router-false:
Expand Down
2 changes: 2 additions & 0 deletions ...ista/avd/molecule/eos_designs_unit_tests/intended/configs/UPLINK_P2P_VRFS_TESTS_LEAF1.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,8 @@ router bgp 65000
address-family ipv4
neighbor IPv4-UNDERLAY-PEERS activate
!
vrf default
!
gmuloc marked this conversation as resolved.
Show resolved Hide resolved
vrf IT
router-id 192.168.42.3
neighbor 10.42.42.10 peer group IPv4-UNDERLAY-PEERS
Expand Down
2 changes: 2 additions & 0 deletions ...ista/avd/molecule/eos_designs_unit_tests/intended/configs/bgp-from-network-services-1.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,5 +121,7 @@ router bgp 65001
address-family ipv4
neighbor MLAG-IPv4-UNDERLAY-PEER activate
neighbor 10.10.1.2 activate
!
vrf default
!
end
Loading
Loading