Refactor(eos_designs): Improve structured_config object duplication checks with opt-in

[ClausHolbechArista]

Change Summary

Improve structured_config object duplication checks with opt-in

Component(s) name

arista.avd.eos_designs

Proposed changes

• Check for duplicate objects across all structured config modules - today we only check within one module
  • Like only finding duplicate interfaces if assigned for different connected endpoints
  • With this we also catch if uplink is the same as a connected endpoint
• This may lead to issues for people "misusing" various protocols to build their configs, so the feature is introduced behind the knob avd_eos_designs_enforce_duplication_checks_across_all_models: true
• The duplication check is moved to the schema-based classes where performance is improved significantly.
  • Now using hash lookup instead of looping over all the items for each added item.
• Refactored connected endpoints ethernet_interfaces and port_channel_interfaces to use the new classes.
  • Fix missing default value for port-channel LACP fallback timer in schema.

How to test

• Added molecule coverage to negative test with the knob enabled.
• Tested performance for the refactor and seeing ~14% performance improvement for this change alone. Expecting many improvements as we refactor the rest.

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4897
# Activate the virtual environment
source test-avd-pr-4897/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/eos_designs/structured_config_rendering#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/eos_designs/structured_config_rendering --force
# Optional: Install AVD examples
cd test-avd-pr-4897
ansible-playbook arista.avd.install_examples

[emilarista]

Tested with some different conflict combos between servers, uplinks and core_interfaces. The new knob works as expected. LGTM!

[ClausHolbechArista]

Address review comments