Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mspa 2678 get options working #41

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Mspa 2678 get options working #41

wants to merge 13 commits into from

Conversation

shanekelly-bbc
Copy link

No description provided.

shanekelly-bbc and others added 11 commits November 16, 2022 10:28
@artemave
Copy link
Owner

artemave commented Dec 4, 2022

This is looking good! Do you mind regenerating Gemfile.lock (with up to date gems) rather than removing it?

@artemave
Copy link
Owner

artemave commented Dec 5, 2022

I am trying to run tests on your branch and I am getting errors:

❯ bundle exec rspec                                                                                                                                                           
                                                                                                                                                                              
An error occurred while loading ./spec/api/app_session_spec.rb.                                                                                                               
Failure/Error: migrate = lambda { ActiveRecord::MigrationContext.new(File.expand_path('../../../db/migrate', __FILE__)).migrate }                                             
                                                                                                                                                                              
ArgumentError:                                                                                                                                                                
  wrong number of arguments (given 5, expected 1..4)                                                                                                                          
# ./lib/rest-assured/config.rb:104:in `block in migrate_db'                                                                                                                   
# ./lib/rest-assured/config.rb:115:in `migrate_db'                                                                                                                            
# ./lib/rest-assured/config.rb:71:in `setup_db'                                                                                                                               
# ./lib/rest-assured/config.rb:44:in `included'                                                                                                                               
# ./lib/rest-assured/application.rb:17:in `include'                                    
# ./lib/rest-assured/application.rb:17:in `<class:Application>'    
# ./lib/rest-assured/application.rb:14:in `<module:RestAssured>'                                                                                                              
# ./lib/rest-assured/application.rb:13:in `<top (required)>'                                                                                                                  
# ./spec/spec_helper.rb:29:in `require'                                                                                                                                       
# ./spec/spec_helper.rb:29:in `<top (required)>'                                                                                                                                                                                                                                                                                                            
# ./spec/api/app_session_spec.rb:2:in `require'                                                                                                                               
# ./spec/api/app_session_spec.rb:2:in `<top (required)>'                                                                                                                                                                                                                                                                                                    
/home/artem/projects/REST-assured/spec/spec_helper.rb:23: warning: already initialized constant DB_OPTS                                                                                                                                                                                                                                                     
/home/artem/projects/REST-assured/spec/spec_helper.rb:23: warning: previous definition of DB_OPTS was here                             
...

❯ bundle exec cucumber
/home/artem/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/activerecord-5.2.8.1/lib/active_record/connection_adapters/abstract/schema_definitions.rb:263:in `initialize': wrong number of arguments (given 5, expected 1..4) (ArgumentError)
        from /home/artem/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/activerecord-5.2.8.1/lib/active_record/connection_adapters/sqlite3/schema_statements.rb:60:in `new'
        from /home/artem/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/activerecord-5.2.8.1/lib/active_record/connection_adapters/sqlite3/schema_statements.rb:60:in `create_table_definition'
        from /home/artem/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/activerecord-5.2.8.1/lib/active_record/connection_adapters/abstract/schema_statements.rb:291:in `create_table'
        from /home/artem/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/activerecord-5.2.8.1/lib/active_record/schema_migration.rb:29:in `create_table'
        from /home/artem/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/activerecord-5.2.8.1/lib/active_record/migration.rb:1187:in `initialize'
        from /home/artem/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/activerecord-5.2.8.1/lib/active_record/migration.rb:1036:in `new'
        from /home/artem/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/activerecord-5.2.8.1/lib/active_record/migration.rb:1036:in `up'
        from /home/artem/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/activerecord-5.2.8.1/lib/active_record/migration.rb:1011:in `migrate'
        from /home/artem/projects/REST-assured/lib/rest-assured/config.rb:104:in `block in migrate_db'
        from /home/artem/projects/REST-assured/lib/rest-assured/config.rb:115:in `migrate_db'
        from /home/artem/projects/REST-assured/lib/rest-assured/config.rb:71:in `setup_db'
        from /home/artem/projects/REST-assured/lib/rest-assured/config.rb:44:in `included'
        from /home/artem/projects/REST-assured/lib/rest-assured/application.rb:17:in `include'
        from /home/artem/projects/REST-assured/lib/rest-assured/application.rb:17:in `<class:Application>'
        from /home/artem/projects/REST-assured/lib/rest-assured/application.rb:14:in `<module:RestAssured>'
        from /home/artem/projects/REST-assured/lib/rest-assured/application.rb:13:in `<top (required)>'
        from bin/rest-assured:73:in `require'
        from bin/rest-assured:73:in `<main>'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GanszkyBalazs GanszkyBalazs GanszkyBalazs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shanekelly-bbc @artemave @GanszkyBalazs @balasubuicentric @wheata03