Clean up.

artie-labs · Oct 21, 2024 · 5a59a7d · 5a59a7d
1 parent b2a3bd2
commit 5a59a7d
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 6 deletions.
diff --git a/lib/debezium/converters/time_test.go b/lib/debezium/converters/time_test.go
@@ -114,13 +114,21 @@ func TestZonedTimestamp_Convert(t *testing.T) {
 }
 
 func TestTime_Convert(t *testing.T) {
+	{
+		val, err := Time{}.Convert(int64(54720321))
+		assert.NoError(t, err)
+
+		extTime, isOk := val.(*ext.ExtendedTime)
+		assert.True(t, isOk)
+		assert.Equal(t, "15:12:00.321", extTime.String(""))
+	}
 	{
 		val, err := Time{}.Convert(int64(54720000))
 		assert.NoError(t, err)
 
 		extTime, isOk := val.(*ext.ExtendedTime)
 		assert.True(t, isOk)
-		assert.Equal(t, "15:12:00+00", extTime.String(""))
+		assert.Equal(t, "15:12:00.000", extTime.String(""))
 	}
 }
 

diff --git a/lib/debezium/schema_test.go b/lib/debezium/schema_test.go
@@ -254,13 +254,20 @@ func TestField_ToKindDetails(t *testing.T) {
 		}
 	}
 	{
-		// Time
-		for _, dbzType := range []SupportedDebeziumType{Time, TimeKafkaConnect, TimeWithTimezone} {
-			kd, err := Field{DebeziumType: dbzType}.ToKindDetails()
+		{
+			// Time with timezone
+			kd, err := Field{DebeziumType: TimeWithTimezone}.ToKindDetails()
 			assert.NoError(t, err)
-			assert.Equal(t, typing.NewExtendedTimeDetails(typing.ETime, ext.TimeKindType, ""), kd, dbzType)
+			assert.Equal(t, typing.NewExtendedTimeDetails(typing.ETime, ext.TimeKindType, ""), kd)
+		}
+		{
+			// Time
+			for _, dbzType := range []SupportedDebeziumType{Time, TimeKafkaConnect, TimeWithTimezone} {
+				kd, err := Field{DebeziumType: dbzType}.ToKindDetails()
+				assert.NoError(t, err)
+				assert.Equal(t, typing.NewExtendedTimeDetails(typing.ETime, ext.TimeKindType, "15:04:05.000"), kd, dbzType)
+			}
 		}
-
 		{
 			// Micro time
 			kd, err := Field{DebeziumType: MicroTime}.ToKindDetails()