Skip to content

Commit

Permalink
PR Feedback.
Browse files Browse the repository at this point in the history
  • Loading branch information
Tang8330 committed Oct 21, 2024
1 parent b65572a commit ad79757
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions lib/optimization/table_data_merge_columns_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,12 @@ func TestTableData_UpdateInMemoryColumnsFromDestination_Tz(t *testing.T) {
{
// In memory is timestamp_ntz and destination is timestamp_tz
tableData := &TableData{inMemoryColumns: &columns.Columns{}}
kd := typing.NewExtendedTimeDetails(typing.ETime, ext.TimestampNTZKindType, "")
kd.ExtendedTimeDetails.Format = ext.RFC3339MillisecondNoTZ
tableData.AddInMemoryCol(columns.NewColumn("foo", kd))
tableData.AddInMemoryCol(
columns.NewColumn(
"foo",
typing.NewExtendedTimeDetails(typing.ETime, ext.TimestampNTZKindType, ext.RFC3339MillisecondNoTZ),
),
)

assert.NoError(t, tableData.MergeColumnsFromDestination(columns.NewColumn("foo", typing.NewExtendedTimeDetails(typing.ETime, ext.TimestampTZKindType, ""))))
updatedColumn, isOk := tableData.inMemoryColumns.GetColumn("foo")
Expand Down

0 comments on commit ad79757

Please sign in to comment.