[typing] Clean up NewDecimalWithPrecision
#778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathan-artie
commented
Jun 27, 2024
| @@ -4,6 +4,13 @@ import ( | |||
| "fmt" | |||
| ) | |||
|
|
|||
| const ( | |||
| DefaultScale int32 = 5 | |||
There was a problem hiding this comment.
Moved these constants too since they are only used for decimal details.
Tang8330
reviewed
Jun 27, 2024
|
|
||
| // This is typically not possible, but Postgres has a design flaw that allows you to do things like: NUMERIC(5, 6) which actually equates to NUMERIC(7, 6) | ||
| // We are setting precision to be scale + 1 to account for the leading zero for decimal numbers. | ||
| precision = scale + 1 |
There was a problem hiding this comment.
How come we don't need this?
There was a problem hiding this comment.
Because we have this exact logic in NewDetails() and we don't read from Decimal.Precision() except for tests.
There was a problem hiding this comment.
Got it. We should refactor the precision function then
func (d *Decimal) Precision() int32 {
return NewDetails(d.precision, d.Scale()).Precision()
}
There was a problem hiding this comment.
I'd just as soon as kill Precision, we don't need it.
Tang8330
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to duplicate the logic for handling invalid decimal precisions since we never read from
Decimal.Precision().