Refactoring Extended Time #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tang8330
commented
Oct 17, 2024
| @@ -11,7 +11,7 @@ import ( | |||
| type ExtendedTimeKindType string | |||
|
|
|||
| const ( | |||
| TimestampTzKindType ExtendedTimeKindType = "timestamp_tz" | |||
| TimestampTZKindType ExtendedTimeKindType = "timestamp_tz" | |||
Tang8330
commented
Oct 17, 2024
| @@ -28,8 +28,8 @@ var ( | |||
| Format: RFC3339NanosecondNoTZ, | |||
| } | |||
|
|
|||
| TimestampTz = NestedKind{ | |||
| Type: TimestampTzKindType, | |||
| TimestampTZ = NestedKind{ | |||
Tang8330
commented
Oct 17, 2024
| @@ -92,15 +93,6 @@ func NewExtendedTimeDetails(details KindDetails, extendedType ext.ExtendedTimeKi | |||
| return details | |||
| } | |||
|
|
|||
| func NewKindDetailsFromTemplate(details KindDetails, extendedType ext.ExtendedTimeKindType) KindDetails { | |||
There was a problem hiding this comment.
Removed this function
danafallon
reviewed
Oct 21, 2024
| @@ -12,7 +12,7 @@ import ( | |||
| type Time struct{} | |||
|
|
|||
| func (Time) ToKindDetails() typing.KindDetails { | |||
| return typing.NewKindDetailsFromTemplate(typing.ETime, ext.TimeKindType) | |||
| return typing.NewExtendedTimeDetails(typing.ETime, ext.TimeKindType, "") | |||
There was a problem hiding this comment.
Should we make this method take a receiver t and use t.layout() as the last arg here?
There was a problem hiding this comment.
We can. Maybe as a 2nd pass? We're not passing a layout into the ExtTime right now.
And if we did, we should be using a ms precision string rather than the default which is microsecond precision
danafallon
reviewed
Oct 21, 2024
| } | ||
| { | ||
| // In memory is timestamp_ntz and destination is timestamp_tz | ||
| tableData := &TableData{inMemoryColumns: &columns.Columns{}} | ||
| kd := typing.NewKindDetailsFromTemplate(typing.ETime, ext.TimestampNTZKindType) | ||
| kd := typing.NewExtendedTimeDetails(typing.ETime, ext.TimestampNTZKindType, "") | ||
| kd.ExtendedTimeDetails.Format = ext.RFC3339MillisecondNoTZ |
There was a problem hiding this comment.
This can be passed into the constructor on the line above, right?
danafallon
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NewKindDetailsFromTemplateTimestampTz