Use time.Time in more places
#976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danafallon
reviewed
Oct 23, 2024
clients/shared/default_value_test.go
Outdated
| @@ -25,7 +25,7 @@ var dialects = []sql.Dialect{ | |||
|
|
|||
| func TestColumn_DefaultValue(t *testing.T) { | |||
| birthday := time.Date(2022, time.September, 6, 3, 19, 24, 942000000, time.UTC) | |||
| birthdayExtDateTime, err := ext.ParseExtendedDateTime(birthday.Format(ext.ISO8601), ext.TimestampTZKindType) | |||
| birthdayExtDateTime, err := ext.ParseDateTime(birthday.Format(ext.ISO8601), ext.TimestampTZKindType) | |||
There was a problem hiding this comment.
Nit: want to rename birthdayExtDateTime to birthdayDateTime?
danafallon
reviewed
Oct 23, 2024
lib/typing/ext/parse_test.go
Outdated
| @@ -18,7 +18,7 @@ func TestParseFromInterface(t *testing.T) { | |||
| for _, val := range vals { | |||
| extTime, err := ParseFromInterface(val, TimestampTZKindType) | |||
danafallon
reviewed
Oct 23, 2024
lib/typing/ext/parse_test.go
Outdated
| @@ -18,7 +18,7 @@ func TestParseFromInterface(t *testing.T) { | |||
| for _, val := range vals { | |||
| extTime, err := ParseFromInterface(val, TimestampTZKindType) | |||
| assert.NoError(t, err) | |||
| assert.Equal(t, val, extTime) | |||
| assert.Equal(t, val.(*ExtendedTime).GetTime(), extTime) | |||
There was a problem hiding this comment.
On line 13, can we declare vals as []ExtendedTime instead of []any so we don't have to cast val here?
There was a problem hiding this comment.
Oh or will that make ParseFromInterface not accept it?
There was a problem hiding this comment.
It can accept ExtendedTime!
danafallon
reviewed
Oct 23, 2024
lib/typing/ext/parse_test.go
Outdated
| assert.NoError(t, err) | ||
| assert.Equal(t, TimeKindType, et.GetNestedKind().Type) | ||
| // Without passing an override format, this should return the same preserved dt format. |
There was a problem hiding this comment.
Is this comment no longer relevant?
There was a problem hiding this comment.
Yup, we don't need it anymore!
danafallon
reviewed
Oct 23, 2024
lib/typing/ext/parse_test.go
Outdated
| assert.NoError(t, err) | ||
| assert.Equal(t, DateKindType, et.GetNestedKind().Type) | ||
|
|
||
| // Without passing an override format, this should return the same preserved dt format. |
danafallon
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title states. The goal is to eventually get rid of
ExtendedTimealtogether.