-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cibuildwheel: update workflow #7805
base: RC_2_0
Are you sure you want to change the base?
Conversation
b64864a
to
9069b89
Compare
@qstokkink I've done a dry-run for all python versions from python 3.9+ across all builds so that the tribler team can test/use them especially for requested macOS 12 prior to it's imminent deprecation/removal as a GH runner image. (Today - 3rd Dec is it's deadline....) I plan on removing macos-12 when it's completely unavailable as a GH runner image from this PR. |
@xavier2k6 Thanks 🙏 I had hoped for a PyPI release before the deadline, but I guess that wasn't in the cards. |
7cc8b3b
to
87d40fd
Compare
87d40fd
to
e014958
Compare
e014958
to
444d1dc
Compare
I plan to do a re-base/one final change after your macos fixes are in-place.....unsure of why windows-2025 is failing & don't really have time to look into it. (will more than likely revert to windows-latest which is currently = windows-2022) |
@@ -126,7 +160,7 @@ jobs: | |||
vcpkg install openssl:x86-windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the condition for this job needs to be updated to also cover CIBW_BUILD
ending with "win_amd64"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or maybe instead look at whether os
starts with "windows-"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The win_amd64
build had no issues previously with windows-2022
...I'll think I'll just revert to that as the windows-2025
image is still classed as beta
& there are still tools etc. been added/updated. (will look in to using it again in a few weeks when v3 of cibuildweel action is released.)
Could also look at updating (manylinux) to build with FORTIFY_SOURCE=3
instead of 2
Is that ok with you??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll rebase/make changes in about an hour or so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on sync? -> #7805 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that would seem reasonable. There's a |
No description provided.