-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checker ruleset for XOMP-files, update handling of units #357
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: DavidJRitter904 <[email protected]>
I have added valid ranges for the following XOMP-properties:
I think this is a good starting point for these value ranges. @ClemensLinnhoff maybe you can add Sandro as well. Is not possible for me to assign. |
@SandroReith could you also review this? |
Signed-off-by: ClemensLinnhoff <[email protected]>
I added some of the reasoning you gave here in the PR to the rules. Then people who read the documentation also know, why these boundaries were chosen. |
Describe your changes
Added checker ruleset for XOMP-files and updated the property units for conformity to documentation.
Issue ticket number and link
Fixes #354 .
Checklist before requesting a review