Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python base library #2

Closed
wants to merge 2 commits into from
Closed

Add Python base library #2

wants to merge 2 commits into from

Conversation

hoangtungdinh
Copy link
Contributor

@hoangtungdinh hoangtungdinh commented Jun 4, 2024 •
edited
Loading

Description

This PR is ready for CCB's review. It includes the first version of the Python base library for the Quality Checker Framework which has the following functionalities:

  1. Read and write a configuration file.
  2. Write a result file. Reading a result file is not supported now and will be added in the future.

Main changes

  1. Add initial setup for the repository
  2. Add Poetry as the package manager
  3. Add qc_baselib initial implementation
  4. Add initial tests
  5. Add test CI/CD workflow

How was the PR tested?

  1. Launched the base unit tests that cover base implementation and all tests are passing.
  2. Test workflows are working as intended.

Notes

This package is structured such that it can be released as a pip package in the future.

This PR is related to the following issue, but it doesn't complete the issue for now as further development is required.
asam-ev/qc-framework#35

andreaskern74
andreaskern74 approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@andreaskern74 andreaskern74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hoangtungdinh hoangtungdinh force-pushed the 2024-06-04 branch 2 times, most recently from c33de11 to c0e8bdd Compare June 12, 2024 13:02
patrickpa added 2 commits June 12, 2024 15:03
@patrickpa @hoangtungdinh
Add initial implementation for base library (#1)
3ef2115 
Signed-off-by: Patrick Abrahão <[email protected]>
Signed-off-by: Patrick Abrahão <[email protected]>
Signed-off-by: Hoang Tung Dinh <[email protected]>
@patrickpa @hoangtungdinh
Update installation instruction on README (#3)
71059d6 
Signed-off-by: Patrick Abrahão <[email protected]>
Signed-off-by: Patrick Abrahão <[email protected]>
Signed-off-by: Hoang Tung Dinh <[email protected]>
@hoangtungdinh hoangtungdinh mentioned this pull request Jun 18, 2024
Merged
@hoangtungdinh
Copy link
Contributor Author

Close this PR as it will be merged via #13

@hoangtungdinh hoangtungdinh deleted the 2024-06-04 branch June 20, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaskern74 andreaskern74 andreaskern74 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Quality Checker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hoangtungdinh @andreaskern74 @AsamDiegoSanchez @patrickpa