Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add domain specific info to result #9

Merged
merged 9 commits into from
Jun 12, 2024
Merged

Add domain specific info to result #9

merged 9 commits into from
Jun 12, 2024

Conversation

patrickpa
Copy link
Contributor

Description

This PR adds the DomainSpecificInfo to the IssueType.

It also fixes some missing details from the previous schema update in the lib.

Main changes

  1. Add DomainSpecificInfo to the IssueType
  2. Add missing location elements methods for Results
  3. Extend tests to check all added and updated cases

How was the PR tested?

  1. Unit-test are passing as intended after updates.

Notes

  • None.

@patrickpa patrickpa requested a review from hoangtungdinh June 11, 2024 16:19
@patrickpa patrickpa self-assigned this Jun 11, 2024
@hoangtungdinh hoangtungdinh merged commit 2ffbfd5 into develop Jun 12, 2024
7 checks passed
@hoangtungdinh hoangtungdinh deleted the patrick/add_domain_specific_info_to_result branch June 12, 2024 12:19
hoangtungdinh
hoangtungdinh reviewed Jun 12, 2024
View reviewed changes
Copy link
Contributor

@hoangtungdinh hoangtungdinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @patrickpa

hoangtungdinh pushed a commit that referenced this pull request Jun 18, 2024
@patrickpa @hoangtungdinh
Add domain specific info to result (#9)
07f8c4a 
Signed-off-by: patrickpa <[email protected]>
@hoangtungdinh hoangtungdinh mentioned this pull request Jun 18, 2024
Merged
hoangtungdinh pushed a commit that referenced this pull request Jun 18, 2024
@patrickpa @hoangtungdinh
Add domain specific info to result (#9)
6cf7822 
Signed-off-by: patrickpa <[email protected]>
Signed-off-by: Patrick Abrahão <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangtungdinh hoangtungdinh hoangtungdinh left review comments

Assignees

@patrickpa patrickpa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrickpa @hoangtungdinh