Update logic to continue checking if one sm has issue

Signed-off-by: hoangtungdinh <[email protected]>
asam-ev · Sep 17, 2024 · 9e978c1 · 9e978c1
1 parent a03fc61
commit 9e978c1
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 92 deletions.
diff --git a/qc_otx/checks/state_machine_checker/distinguished_initial_and_completed_state.py b/qc_otx/checks/state_machine_checker/distinguished_initial_and_completed_state.py
@@ -78,39 +78,15 @@ def check_rule(checker_data: models.CheckerData) -> None:
         state_machine = utils.get_state_machine(state_machine_procedure, nsmap)
 
         if state_machine is None:
-            checker_data.result.set_checker_status(
-                checker_bundle_name=constants.BUNDLE_NAME,
-                checker_id=CHECKER_ID,
-                status=StatusType.SKIPPED,
-            )
-
-            checker_data.result.add_checker_summary(
-                constants.BUNDLE_NAME,
-                CHECKER_ID,
-                f"State machine not found. Skip the check.",
-            )
-
-            return
+            continue
 
         smp_realisation = state_machine_procedure.xpath(
             "./smp:realisation", namespaces=nsmap
         )
         logging.debug(f"smp_realisation: {smp_realisation}")
 
         if smp_realisation is None or len(smp_realisation) != 1:
-            checker_data.result.set_checker_status(
-                checker_bundle_name=constants.BUNDLE_NAME,
-                checker_id=CHECKER_ID,
-                status=StatusType.SKIPPED,
-            )
-
-            checker_data.result.add_checker_summary(
-                constants.BUNDLE_NAME,
-                CHECKER_ID,
-                f"Invalid realisation found in state machine procedure. Skip the check.",
-            )
-
-            return
+            continue
 
         smp_realisation = smp_realisation[0]
 

diff --git a/qc_otx/checks/state_machine_checker/mandatory_target_state.py b/qc_otx/checks/state_machine_checker/mandatory_target_state.py
@@ -70,19 +70,7 @@ def check_rule(checker_data: models.CheckerData) -> None:
         state_machine = utils.get_state_machine(state_machine_procedure, nsmap)
 
         if state_machine is None:
-            checker_data.result.set_checker_status(
-                checker_bundle_name=constants.BUNDLE_NAME,
-                checker_id=CHECKER_ID,
-                status=StatusType.SKIPPED,
-            )
-
-            checker_data.result.add_checker_summary(
-                constants.BUNDLE_NAME,
-                CHECKER_ID,
-                f"State machine not found. Skip the check.",
-            )
-
-            return
+            continue
 
         for sm_state in state_machine.states:
             has_issue = (

diff --git a/qc_otx/checks/state_machine_checker/mandatory_transition.py b/qc_otx/checks/state_machine_checker/mandatory_transition.py
@@ -72,19 +72,7 @@ def check_rule(checker_data: models.CheckerData) -> None:
         state_machine = utils.get_state_machine(state_machine_procedure, nsmap)
 
         if state_machine is None:
-            checker_data.result.set_checker_status(
-                checker_bundle_name=constants.BUNDLE_NAME,
-                checker_id=CHECKER_ID,
-                status=StatusType.SKIPPED,
-            )
-
-            checker_data.result.add_checker_summary(
-                constants.BUNDLE_NAME,
-                CHECKER_ID,
-                f"State machine not found. Skip the check.",
-            )
-
-            return
+            continue
 
         for sm_state in state_machine.states:
             has_issue = not sm_state.is_completed and len(sm_state.transitions) == 0

diff --git a/qc_otx/checks/state_machine_checker/mandatory_trigger.py b/qc_otx/checks/state_machine_checker/mandatory_trigger.py
@@ -72,20 +72,7 @@ def check_rule(checker_data: models.CheckerData) -> None:
         state_machine = utils.get_state_machine(state_machine_procedure, nsmap)
 
         if state_machine is None:
-
-            checker_data.result.set_checker_status(
-                checker_bundle_name=constants.BUNDLE_NAME,
-                checker_id=CHECKER_ID,
-                status=StatusType.SKIPPED,
-            )
-
-            checker_data.result.add_checker_summary(
-                constants.BUNDLE_NAME,
-                CHECKER_ID,
-                f"State machine not found. Skip the check.",
-            )
-
-            return
+            continue
 
         for sm_state in state_machine.states:
             has_issue = not sm_state.is_completed and len(sm_state.triggers) == 0

diff --git a/qc_otx/checks/state_machine_checker/no_target_state_for_completed_state.py b/qc_otx/checks/state_machine_checker/no_target_state_for_completed_state.py
@@ -73,19 +73,7 @@ def check_rule(checker_data: models.CheckerData) -> None:
         state_machine = utils.get_state_machine(state_machine_procedure, nsmap)
 
         if state_machine is None:
-            checker_data.result.set_checker_status(
-                checker_bundle_name=constants.BUNDLE_NAME,
-                checker_id=CHECKER_ID,
-                status=StatusType.SKIPPED,
-            )
-
-            checker_data.result.add_checker_summary(
-                constants.BUNDLE_NAME,
-                CHECKER_ID,
-                f"State machine not found. Skip the check.",
-            )
-
-            return
+            continue
 
         completed_state = None
         for sm_state in state_machine.states:
@@ -94,19 +82,7 @@ def check_rule(checker_data: models.CheckerData) -> None:
                 break
 
         if completed_state is None:
-            checker_data.result.set_checker_status(
-                checker_bundle_name=constants.BUNDLE_NAME,
-                checker_id=CHECKER_ID,
-                status=StatusType.SKIPPED,
-            )
-
-            checker_data.result.add_checker_summary(
-                constants.BUNDLE_NAME,
-                CHECKER_ID,
-                f"Completed state not found. Skip the check.",
-            )
-
-            return
+            continue
 
         has_issue = len(completed_state.target_state_ids) != 0
         if has_issue: