Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add maintenance work #35

Merged
merged 5 commits into from
Sep 26, 2024
Merged

Add maintenance work #35

merged 5 commits into from
Sep 26, 2024

Conversation

hoangtungdinh
Copy link
Contributor

Description

This PR includes various maintenance work.

Main changes

  1. Refactor to use one checker per rule
  2. Update issue description
  3. Add summary to result file and improve some checks
  4. Refactor and clean up the architecture

How was the PR tested?

  1. Tests are documented in each PR.

Notes
This PR closes the following issues

@hoangtungdinh hoangtungdinh added the isState:ForCCBReview CCB will review it and change the status to ReadyForMerge if everything is ok label Sep 25, 2024
@AsamDiegoSanchez
Copy link
Member

In CCB reviewed. Ready to be merged

@AsamDiegoSanchez AsamDiegoSanchez added isState:ReadyForMerge and removed isState:ForCCBReview CCB will review it and change the status to ReadyForMerge if everything is ok labels Sep 26, 2024
@andreaskern74 andreaskern74 merged commit ede73bd into main Sep 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaskern74 andreaskern74 andreaskern74 approved these changes

Assignees
No one assigned
Labels
isState:Integrated
Projects
Quality Checker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hoangtungdinh @AsamDiegoSanchez @andreaskern74 @romanodanilo