Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update baselib and use Optional #37

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Update baselib and use Optional #37

merged 1 commit into from
Oct 7, 2024

Conversation

hoangtungdinh
Copy link
Contributor

Description

This is the last PR to prepare for the release candidate v1.0.0-rc.1

Main changes

  1. Use asam-qc-baselib from PyPi with version range ^1.0.0rc1
  2. Use typing.Optional

How was the PR tested?

  1. Unit-test
  2. Test release asam-qc-otx on the test PyPi server. Install the published package locally and it works.

Notes

@hoangtungdinh
Update baselib and use Optional
e294476 
Signed-off-by: hoangtungdinh <[email protected]>
romanodanilo
romanodanilo approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@romanodanilo romanodanilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @hoangtungdinh

@hoangtungdinh hoangtungdinh merged commit 6319446 into develop Oct 7, 2024
6 checks passed
@hoangtungdinh hoangtungdinh deleted the tung/baselib branch October 7, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanodanilo romanodanilo romanodanilo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoangtungdinh @romanodanilo