Remove USING_STATIC_XERCES as this is not necessary anymore since XercesC 3.2.0 #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunBlack
force-pushed
the
remove_USING_STATIC_XERCES
branch
from
1ac8a8c to
0c7c65a
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since when updating the lib in vcpkg the question came up why
USING_STATIC_XERCESis needed (microsoft/vcpkg#42498), I looked a little deeper and it seems like it's a leftover from before they natively supported CMake in 3.2.0. Since 3.2.0 came out in 2017, it should be okay to stop supporting all older versions and base them on config mode. I have also suggested deprecating the old XercesC module in CMake, therefore already enforcing the config mode,// Edit: Removed the force of using the Config module, as Xerces-C can be still build with a
configure.acfile, where the CMake files were missing later. But asXERCES_STATIC_LIBRARYstill seems to be obsolete since 3.2.0, removingUSING_STATIC_XERCESseems to be okay.