Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: do not ask for an unused GitLab token scope #355

Merged

Conversation

alessio-locatelli
Copy link
Contributor

I verified by using my personal read_api token and running all-repos-clone -j 1.

@alessio-locatelli alessio-locatelli marked this pull request as ready for review December 27, 2024 13:35
@asottile
Copy link
Owner

did you clone any private repos?

@alessio-locatelli
Copy link
Contributor Author

alessio-locatelli commented Dec 27, 2024

did you clone any private repos?

Yes, I did. I only have private repositories on GitLab.


Click to expand

By the way, according to https://docs.gitlab.com/ee/user/profile/personal_access_tokens.html, the read_repository scope could only be required for git-over-HTTP (not using the API), which should not be the use case for all-repos, unless I missed something in the source.

@asottile asottile merged commit 9b5f613 into asottile:main Dec 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants