Standardize incoming introspection #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on #76 . |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #77 +/- ##
==========================================
+ Coverage 75.00% 75.08% +0.08%
==========================================
Files 51 50 -1
Lines 840 839 -1
==========================================
Hits 630 630
+ Misses 210 209 -1 ☔ View full report in Codecov by Sentry. |
Annopaolo
added a commit
to Annopaolo/astarte
that referenced
this pull request
Dec 4, 2023
Incoming introspection triggers define introspection as a map
interface_name => %IntrospectionEntry{major: _, minor: _}
rather than a plaintext string.
See astarte-platform/astarte_core#77.
Signed-off-by: Arnaldo Cesco <[email protected]>
Annopaolo
force-pushed
the
standardize-incoming-introspection
branch
2 times, most recently
from
089d934 to
6308c42
Compare
Annopaolo
force-pushed
the
standardize-incoming-introspection
branch
from
6308c42 to
38a8b57
Compare
Annopaolo
force-pushed
the
standardize-incoming-introspection
branch
from
38a8b57 to
7eb7e20
Compare
IncomingIntrospectionEvent holds now a map
interface-name -> {major, minor}.
Keep the old plain introspection string as
a deprecated field.
Signed-off-by: Arnaldo Cesco <[email protected]>
Annopaolo
force-pushed
the
standardize-incoming-introspection
branch
from
7eb7e20 to
3a4fe8d
Compare
rbino
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The payload should be an interface -> (major, minor) map, and not just a string.
Replace the old
introspectionfield (a string) with theinstrospection_mapfield.Keep the old plain introspection string as deprecated.