B901: Misses yield sub-expresisons
#14453
Assignees
Labels
Comments
MichaReiser
added
bug
hmm, this isn't valid syntax: >>> from typing import *
>>> from pathlib import Path
>>> def get_file_paths(file_types: Iterable[str] | None = None) -> Iterable[Path]:
... dir_path = Path(".")
... if file_types is None:
... return dir_path.glob("*")
...
... for file_type in file_types:
... (yield a for a in dir_path.glob(f"*.{file_type}"))
...
File "<python-input-2>", line 7
(yield a for a in dir_path.glob(f"*.{file_type}"))
^^^
SyntaxError: invalid syntax |
|
hmm, I only tested with our parser. nested yield expressions are definitely valid :) |
|
Okay, found one |
|
Here's another function that is a generator function with a def f():
x = yield
print(x)
return 42This is a generator function that you can >>> def f():
... x = yield
... print(x)
... return 42
...
>>> y = f()
>>> next(y)
>>> y.send('foo')
foo
Traceback (most recent call last):
File "<python-input-13>", line 1, in <module>
y.send('foo')
~~~~~~^^^^^^^
StopIteration: 42
|
|
Hi @MichaReiser @AlexWaygood can I help you fix this issue ? |
|
Sure. You can find the code for this rule in this file |
|
Thanks @MichaReiser excited to work on this ! |
kaspell
added a commit
to kaspell/ruff
that referenced
this issue
Jan 4, 2025
Currently, the B901 rule misses yield expressions that are not top-of-tree, for example as in def f(): x = yield print(x) return 42 This commit refactors the rule to find such yield expressions. Assignments are traversed and identifiers bound to yield or yield from expressions are tracked, so that if those variables are later returned (which is valid), the rule is not triggered. The assignment traversal part is inspired by the match_value and match_target functions from src/analyze/typing.rs in the ruff_python_semantic crate. The relevant issue is astral-sh#14453.
kaspell
added a commit
to kaspell/ruff
that referenced
this issue
Jan 4, 2025
Currently, the B901 rule misses yield expressions that are not top-of-tree, for example as in def f(): x = yield print(x) return 42 This commit refactors the rule to find such yield expressions. Assignments are traversed and identifiers bound to yield or yield from expressions are tracked, so that if the value bound to those identifiers are later returned (which is valid), the rule is not triggered. The assignment traversal part is inspired by the match_value and match_target functions from src/analyze/typing.rs in the ruff_python_semantic crate. The relevant issue is astral-sh#14453.
kaspell
added a commit
to kaspell/ruff
that referenced
this issue
Jan 4, 2025
Currently, the B901 rule misses yield expressions that are not top-of-tree in a function body, for example as in def f(): x = yield print(x) return 42 This commit refactors the rule to find such yield expressions. Assignments are traversed and identifiers bound to yield or yield from expressions are tracked, so that if a value bound to those identifiers is later returned (which is valid), the rule is not triggered. The assignment traversal part is inspired by the match_value and match_target functions from src/analyze/typing.rs in the ruff_python_semantic crate. The relevant issue is astral-sh#14453.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A very contrived example but
B901misses yield expressions where they're not the expression of aExprStmt.Note: we should make sure that we don't traverse into any lambda expressions...
The text was updated successfully, but these errors were encountered: