[ruff] Recognize more expressions (RUF027)
#15247
Open
+238
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| RUF027 | 29 | 29 | 0 | 0 | 0 |
|
The true-positive-turned-false-negative: raise ValueError(
"Scale {scale!r} is not in the allowed scales {sorted(self.SCALES)}"
)#9849 has a bit more context on why strings whose placeholders' names are the same as that of built-ins are ignored. This interacted poorly with the new logic; in addition, it fails to recognize dunder names: print('{__path__}') # Currently a false negative |
|
The new changes introduced a few true positives, most notably: params_path.write_text(dedent(r"""
...
generated_parameters = {
__params__
}
""").replace("__params__", reindent("".join(params), 1)))geodetic_base_doc = """{__doc__}
...
"""
@format_doc(geodetic_base_doc)
class BaseGeodeticRepresentation(BaseRepresentation): ...The former is embedded code, while the latter is dynamically interpolated. These cannot be detected reliably in the first place, so I think the false positives are acceptable. |
|
I haven't looked at this PR yet, but note that RUF027 already has too many false positives for us to consider stabilising it. I definitely don't think we should be making changes that introduce new false positives here, honestly |
|
If so, this PR might as well be closed, as this is now considered an error: python_major_minor_version = run_command(
[
str(PYTHON_BIN_PATH),
"-c",
"import sys; print(f'{sys.version_info.major}.{sys.version_info.minor}')",
],
).stdout.strip() |
|
It does find some new actual violations but we should look into if we can find a way to reduce the false positives. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #15227.
Test Plan
cargo nextest runandcargo insta test.