Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fix in ecosystem check #15267

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

eclbg
Copy link
Contributor

@eclbg eclbg commented Jan 5, 2025

Summary

Close #15146
Available fixes won't be applied in ecosystem checks even when the checked repository has fix = true in their settings. This way the check output better reflects the actual changes in a given branch.

Test Plan

I've run the ecosystem checks locally and compared the outputs before and after the change. I used a build from main and a build from #15139, which is where the need to make this change was identified. The branch in question only adds a fix, so it is expected that the ecosystem checks only find new fixes. These are the results (unfold to see full):

Before the change: +0 -133 violations, +390 -0 fixes in 19 projects; 36 projects unchanged
DisnakeDev/disnake (+0 -0 violations, +2 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ tests/test_utils.py:782:25: RUF036 [*] `None` not at the end of the type annotation.
- tests/test_utils.py:782:25: RUF036 `None` not at the end of the type annotation.

RasaHQ/rasa (+0 -0 violations, +6 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ rasa/shared/core/events.py:597:48: RUF036 [*] `None` not at the end of the type annotation.
- rasa/shared/core/events.py:597:48: RUF036 `None` not at the end of the type annotation.
+ rasa/shared/core/events.py:624:31: RUF036 [*] `None` not at the end of the type annotation.
- rasa/shared/core/events.py:624:31: RUF036 `None` not at the end of the type annotation.
+ rasa/utils/tensorflow/models.py:247:35: RUF036 [*] `None` not at the end of the type annotation.
- rasa/utils/tensorflow/models.py:247:35: RUF036 `None` not at the end of the type annotation.

apache/airflow (+0 -0 violations, +242 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ airflow/api_fastapi/common/parameters.py:641:22: RUF036 [*] `None` not at the end of the type annotation.
- airflow/api_fastapi/common/parameters.py:641:22: RUF036 `None` not at the end of the type annotation.
+ airflow/auth/managers/base_auth_manager.py:448:36: RUF036 [*] `None` not at the end of the type annotation.
- airflow/auth/managers/base_auth_manager.py:448:36: RUF036 `None` not at the end of the type annotation.
+ airflow/cli/commands/remote_commands/task_command.py:250:71: RUF036 [*] `None` not at the end of the type annotation.
- airflow/cli/commands/remote_commands/task_command.py:250:71: RUF036 `None` not at the end of the type annotation.
+ airflow/cli/commands/remote_commands/task_command.py:336:46: RUF036 [*] `None` not at the end of the type annotation.
- airflow/cli/commands/remote_commands/task_command.py:336:46: RUF036 `None` not at the end of the type annotation.
+ airflow/decorators/__init__.pyi:117:23: RUF036 [*] `None` not at the end of the type annotation.
- airflow/decorators/__init__.pyi:117:23: RUF036 `None` not at the end of the type annotation.
+ airflow/decorators/__init__.pyi:118:25: RUF036 [*] `None` not at the end of the type annotation.
- airflow/decorators/__init__.pyi:118:25: RUF036 `None` not at the end of the type annotation.
+ airflow/decorators/__init__.pyi:124:21: RUF036 [*] `None` not at the end of the type annotation.
- airflow/decorators/__init__.pyi:124:21: RUF036 `None` not at the end of the type annotation.
+ airflow/decorators/__init__.pyi:125:26: RUF036 [*] `None` not at the end of the type annotation.
- airflow/decorators/__init__.pyi:125:26: RUF036 `None` not at the end of the type annotation.
+ airflow/decorators/__init__.pyi:245:23: RUF036 [*] `None` not at the end of the type annotation.
- airflow/decorators/__init__.pyi:245:23: RUF036 `None` not at the end of the type annotation.
+ airflow/decorators/__init__.pyi:246:25: RUF036 [*] `None` not at the end of the type annotation.
- airflow/decorators/__init__.pyi:246:25: RUF036 `None` not at the end of the type annotation.
+ airflow/decorators/__init__.pyi:252:21: RUF036 [*] `None` not at the end of the type annotation.
- airflow/decorators/__init__.pyi:252:21: RUF036 `None` not at the end of the type annotation.
+ airflow/decorators/__init__.pyi:253:26: RUF036 [*] `None` not at the end of the type annotation.
... 219 additional changes omitted for project

apache/superset (+0 -0 violations, +10 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ superset/config.py:1126:5: RUF036 [*] `None` not at the end of the type annotation.
- superset/config.py:1126:5: RUF036 `None` not at the end of the type annotation.
+ superset/config.py:1728:43: RUF036 [*] `None` not at the end of the type annotation.
- superset/config.py:1728:43: RUF036 `None` not at the end of the type annotation.
+ superset/config.py:713:5: RUF036 [*] `None` not at the end of the type annotation.
- superset/config.py:713:5: RUF036 `None` not at the end of the type annotation.
+ superset/db_engine_specs/gsheets.py:166:26: RUF036 [*] `None` not at the end of the type annotation.
- superset/db_engine_specs/gsheets.py:166:26: RUF036 `None` not at the end of the type annotation.
+ superset/jinja_context.py:84:16: RUF036 [*] `None` not at the end of the type annotation.
- superset/jinja_context.py:84:16: RUF036 `None` not at the end of the type annotation.

bokeh/bokeh (+0 -0 violations, +6 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ src/bokeh/client/websocket.py:73:85: RUF036 [*] `None` not at the end of the type annotation.
- src/bokeh/client/websocket.py:73:85: RUF036 `None` not at the end of the type annotation.
+ src/bokeh/embed/standalone.py:84:30: RUF036 [*] `None` not at the end of the type annotation.
- src/bokeh/embed/standalone.py:84:30: RUF036 `None` not at the end of the type annotation.
+ src/bokeh/util/tornado.py:231:26: RUF036 [*] `None` not at the end of the type annotation.
- src/bokeh/util/tornado.py:231:26: RUF036 `None` not at the end of the type annotation.

latchbio/latch (+0 -0 violations, +14 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ src/latch/registry/types.py:45:5: RUF036 [*] `None` not at the end of the type annotation.
- src/latch/registry/types.py:45:5: RUF036 `None` not at the end of the type annotation.
+ src/latch/types/metadata.py:419:5: RUF036 [*] `None` not at the end of the type annotation.
- src/latch/types/metadata.py:419:5: RUF036 `None` not at the end of the type annotation.
+ src/latch_cli/services/get.py:38:32: RUF036 [*] `None` not at the end of the type annotation.
- src/latch_cli/services/get.py:38:32: RUF036 `None` not at the end of the type annotation.
+ src/latch_cli/services/launch.py:135:46: RUF036 [*] `None` not at the end of the type annotation.
- src/latch_cli/services/launch.py:135:46: RUF036 `None` not at the end of the type annotation.
+ src/latch_cli/snakemake/config/utils.py:12:53: RUF036 [*] `None` not at the end of the type annotation.
- src/latch_cli/snakemake/config/utils.py:12:53: RUF036 `None` not at the end of the type annotation.
... 4 additional changes omitted for project

lnbits/lnbits (+0 -0 violations, +2 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ lnbits/core/views/payment_api.py:172:27: RUF036 [*] `None` not at the end of the type annotation.
- lnbits/core/views/payment_api.py:172:27: RUF036 `None` not at the end of the type annotation.

milvus-io/pymilvus (+0 -0 violations, +2 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ pymilvus/client/abstract.py:810:40: RUF036 [*] `None` not at the end of the type annotation.
- pymilvus/client/abstract.py:810:40: RUF036 `None` not at the end of the type annotation.

pandas-dev/pandas (+0 -41 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

- pandas/core/dtypes/cast.py:182:38: RUF036 `None` not at the end of the type annotation.
- pandas/core/dtypes/cast.py:182:65: RUF036 `None` not at the end of the type annotation.
- pandas/core/dtypes/dtypes.py:1269:15: RUF036 `None` not at the end of the type annotation.
- pandas/core/generic.py:6829:15: RUF036 `None` not at the end of the type annotation.
- pandas/core/generic.py:6831:16: RUF036 `None` not at the end of the type annotation.
- pandas/core/generic.py:7124:15: RUF036 `None` not at the end of the type annotation.
- pandas/core/generic.py:7126:16: RUF036 `None` not at the end of the type annotation.
- pandas/core/generic.py:7134:15: RUF036 `None` not at the end of the type annotation.
- pandas/core/generic.py:7136:16: RUF036 `None` not at the end of the type annotation.
- pandas/core/generic.py:7144:15: RUF036 `None` not at the end of the type annotation.
... 31 additional changes omitted for project

pypa/cibuildwheel (+0 -0 violations, +2 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ cibuildwheel/options.py:753:41: RUF036 [*] `None` not at the end of the type annotation.
- cibuildwheel/options.py:753:41: RUF036 `None` not at the end of the type annotation.

python/typeshed (+0 -89 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select E,F,FA,I,PYI,RUF,UP,W

- stdlib/_interpreters.pyi:26:6: RUF036 `None` not at the end of the type annotation.
- stdlib/_ssl.pyi:79:58: RUF036 `None` not at the end of the type annotation.
- stdlib/ast.pyi:1743:26: RUF036 `None` not at the end of the type annotation.
- stdlib/ast.pyi:1753:26: RUF036 `None` not at the end of the type annotation.
- stdlib/ast.pyi:1763:26: RUF036 `None` not at the end of the type annotation.
- stdlib/ast.pyi:1773:26: RUF036 `None` not at the end of the type annotation.
- stdlib/ast.pyi:1782:26: RUF036 `None` not at the end of the type annotation.
- stdlib/ast.pyi:1791:26: RUF036 `None` not at the end of the type annotation.
- stdlib/ast.pyi:1800:26: RUF036 `None` not at the end of the type annotation.
- stdlib/ast.pyi:1810:26: RUF036 `None` not at the end of the type annotation.
... 79 additional changes omitted for project

python-poetry/poetry (+0 -3 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

- src/poetry/utils/env/env_manager.py:117:35: RUF036 `None` not at the end of the type annotation.
- src/poetry/utils/env/env_manager.py:142:13: RUF036 `None` not at the end of the type annotation.
- src/poetry/utils/env/env_manager.py:96:44: RUF036 `None` not at the end of the type annotation.

... Truncated remaining completed project reports due to GitHub comment length restrictions

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
RUF036 523 0 133 390 0

After the change: +0 -0 violations, +786 -0 fixes in 19 projects; 36 projects unchanged ℹ️ ecosystem check **detected linter changes**. (+0 -0 violations, +786 -0 fixes in 19 projects; 36 projects unchanged)
DisnakeDev/disnake (+0 -0 violations, +2 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview

+ tests/test_utils.py:782:25: RUF036 [*] `None` not at the end of the type annotation.
- tests/test_utils.py:782:25: RUF036 `None` not at the end of the type annotation.

RasaHQ/rasa (+0 -0 violations, +6 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview

+ rasa/shared/core/events.py:597:48: RUF036 [*] `None` not at the end of the type annotation.
- rasa/shared/core/events.py:597:48: RUF036 `None` not at the end of the type annotation.
+ rasa/shared/core/events.py:624:31: RUF036 [*] `None` not at the end of the type annotation.
- rasa/shared/core/events.py:624:31: RUF036 `None` not at the end of the type annotation.
+ rasa/utils/tensorflow/models.py:247:35: RUF036 [*] `None` not at the end of the type annotation.
- rasa/utils/tensorflow/models.py:247:35: RUF036 `None` not at the end of the type annotation.

apache/airflow (+0 -0 violations, +242 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL

+ airflow/api_fastapi/common/parameters.py:641:22: RUF036 [*] `None` not at the end of the type annotation.
- airflow/api_fastapi/common/parameters.py:641:22: RUF036 `None` not at the end of the type annotation.
+ airflow/auth/managers/base_auth_manager.py:448:36: RUF036 [*] `None` not at the end of the type annotation.
- airflow/auth/managers/base_auth_manager.py:448:36: RUF036 `None` not at the end of the type annotation.
+ airflow/cli/commands/remote_commands/task_command.py:250:71: RUF036 [*] `None` not at the end of the type annotation.
- airflow/cli/commands/remote_commands/task_command.py:250:71: RUF036 `None` not at the end of the type annotation.
+ airflow/cli/commands/remote_commands/task_command.py:336:46: RUF036 [*] `None` not at the end of the type annotation.
- airflow/cli/commands/remote_commands/task_command.py:336:46: RUF036 `None` not at the end of the type annotation.
+ airflow/decorators/__init__.pyi:117:23: RUF036 [*] `None` not at the end of the type annotation.
- airflow/decorators/__init__.pyi:117:23: RUF036 `None` not at the end of the type annotation.
+ airflow/decorators/__init__.pyi:118:25: RUF036 [*] `None` not at the end of the type annotation.
- airflow/decorators/__init__.pyi:118:25: RUF036 `None` not at the end of the type annotation.
+ airflow/decorators/__init__.pyi:124:21: RUF036 [*] `None` not at the end of the type annotation.
- airflow/decorators/__init__.pyi:124:21: RUF036 `None` not at the end of the type annotation.
+ airflow/decorators/__init__.pyi:125:26: RUF036 [*] `None` not at the end of the type annotation.
... 227 additional changes omitted for project

apache/superset (+0 -0 violations, +10 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL

+ superset/config.py:1126:5: RUF036 [*] `None` not at the end of the type annotation.
- superset/config.py:1126:5: RUF036 `None` not at the end of the type annotation.
+ superset/config.py:1728:43: RUF036 [*] `None` not at the end of the type annotation.
- superset/config.py:1728:43: RUF036 `None` not at the end of the type annotation.
+ superset/config.py:713:5: RUF036 [*] `None` not at the end of the type annotation.
- superset/config.py:713:5: RUF036 `None` not at the end of the type annotation.
+ superset/db_engine_specs/gsheets.py:166:26: RUF036 [*] `None` not at the end of the type annotation.
- superset/db_engine_specs/gsheets.py:166:26: RUF036 `None` not at the end of the type annotation.
+ superset/jinja_context.py:84:16: RUF036 [*] `None` not at the end of the type annotation.
- superset/jinja_context.py:84:16: RUF036 `None` not at the end of the type annotation.

bokeh/bokeh (+0 -0 violations, +6 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL

+ src/bokeh/client/websocket.py:73:85: RUF036 [*] `None` not at the end of the type annotation.
- src/bokeh/client/websocket.py:73:85: RUF036 `None` not at the end of the type annotation.
+ src/bokeh/embed/standalone.py:84:30: RUF036 [*] `None` not at the end of the type annotation.
- src/bokeh/embed/standalone.py:84:30: RUF036 `None` not at the end of the type annotation.
+ src/bokeh/util/tornado.py:231:26: RUF036 [*] `None` not at the end of the type annotation.
- src/bokeh/util/tornado.py:231:26: RUF036 `None` not at the end of the type annotation.

latchbio/latch (+0 -0 violations, +14 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview

+ src/latch/registry/types.py:45:5: RUF036 [*] `None` not at the end of the type annotation.
- src/latch/registry/types.py:45:5: RUF036 `None` not at the end of the type annotation.
+ src/latch/types/metadata.py:419:5: RUF036 [*] `None` not at the end of the type annotation.
- src/latch/types/metadata.py:419:5: RUF036 `None` not at the end of the type annotation.
+ src/latch_cli/services/get.py:38:32: RUF036 [*] `None` not at the end of the type annotation.
- src/latch_cli/services/get.py:38:32: RUF036 `None` not at the end of the type annotation.
+ src/latch_cli/services/launch.py:135:46: RUF036 [*] `None` not at the end of the type annotation.
- src/latch_cli/services/launch.py:135:46: RUF036 `None` not at the end of the type annotation.
+ src/latch_cli/snakemake/config/utils.py:12:53: RUF036 [*] `None` not at the end of the type annotation.
- src/latch_cli/snakemake/config/utils.py:12:53: RUF036 `None` not at the end of the type annotation.
... 4 additional changes omitted for project

lnbits/lnbits (+0 -0 violations, +2 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview

+ lnbits/core/views/payment_api.py:172:27: RUF036 [*] `None` not at the end of the type annotation.
- lnbits/core/views/payment_api.py:172:27: RUF036 `None` not at the end of the type annotation.

milvus-io/pymilvus (+0 -0 violations, +2 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview

+ pymilvus/client/abstract.py:810:40: RUF036 [*] `None` not at the end of the type annotation.
- pymilvus/client/abstract.py:810:40: RUF036 `None` not at the end of the type annotation.

pandas-dev/pandas (+0 -0 violations, +114 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview

+ pandas/_libs/json.pyi:14:22: RUF036 [*] `None` not at the end of the type annotation.
- pandas/_libs/json.pyi:14:22: RUF036 `None` not at the end of the type annotation.
+ pandas/_libs/tslibs/timedeltas.pyi:147:36: RUF036 [*] `None` not at the end of the type annotation.
- pandas/_libs/tslibs/timedeltas.pyi:147:36: RUF036 `None` not at the end of the type annotation.
+ pandas/_libs/tslibs/timestamps.pyi:30:41: RUF036 [*] `None` not at the end of the type annotation.
- pandas/_libs/tslibs/timestamps.pyi:30:41: RUF036 `None` not at the end of the type annotation.
+ pandas/core/arrays/datetimelike.py:1040:45: RUF036 [*] `None` not at the end of the type annotation.
- pandas/core/arrays/datetimelike.py:1040:45: RUF036 `None` not at the end of the type annotation.
+ pandas/core/dtypes/cast.py:182:38: RUF036 [*] `None` not at the end of the type annotation.
- pandas/core/dtypes/cast.py:182:38: RUF036 `None` not at the end of the type annotation.
... 104 additional changes omitted for project

pypa/cibuildwheel (+0 -0 violations, +2 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview

+ cibuildwheel/options.py:753:41: RUF036 [*] `None` not at the end of the type annotation.
- cibuildwheel/options.py:753:41: RUF036 `None` not at the end of the type annotation.

python/typeshed (+0 -0 violations, +276 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select E,F,FA,I,PYI,RUF,UP,W

+ stdlib/_interpreters.pyi:26:6: RUF036 [*] `None` not at the end of the type annotation.
- stdlib/_interpreters.pyi:26:6: RUF036 `None` not at the end of the type annotation.
+ stdlib/_ssl.pyi:79:58: RUF036 [*] `None` not at the end of the type annotation.
- stdlib/_ssl.pyi:79:58: RUF036 `None` not at the end of the type annotation.
+ stdlib/ast.pyi:1743:26: RUF036 [*] `None` not at the end of the type annotation.
- stdlib/ast.pyi:1743:26: RUF036 `None` not at the end of the type annotation.
+ stdlib/ast.pyi:1753:26: RUF036 [*] `None` not at the end of the type annotation.
- stdlib/ast.pyi:1753:26: RUF036 `None` not at the end of the type annotation.
+ stdlib/ast.pyi:1763:26: RUF036 [*] `None` not at the end of the type annotation.
- stdlib/ast.pyi:1763:26: RUF036 `None` not at the end of the type annotation.
+ stdlib/ast.pyi:1773:26: RUF036 [*] `None` not at the end of the type annotation.
- stdlib/ast.pyi:1773:26: RUF036 `None` not at the end of the type annotation.
+ stdlib/ast.pyi:1782:26: RUF036 [*] `None` not at the end of the type annotation.
- stdlib/ast.pyi:1782:26: RUF036 `None` not at the end of the type annotation.
+ stdlib/ast.pyi:1791:26: RUF036 [*] `None` not at the end of the type annotation.
- stdlib/ast.pyi:1791:26: RUF036 `None` not at the end of the type annotation.
+ stdlib/ast.pyi:1800:26: RUF036 [*] `None` not at the end of the type annotation.
... 259 additional changes omitted for project

python-poetry/poetry (+0 -0 violations, +6 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview

+ src/poetry/utils/env/env_manager.py:117:35: RUF036 [*] `None` not at the end of the type annotation.
- src/poetry/utils/env/env_manager.py:117:35: RUF036 `None` not at the end of the type annotation.
+ src/poetry/utils/env/env_manager.py:142:13: RUF036 [*] `None` not at the end of the type annotation.
- src/poetry/utils/env/env_manager.py:142:13: RUF036 `None` not at the end of the type annotation.
+ src/poetry/utils/env/env_manager.py:96:44: RUF036 [*] `None` not at the end of the type annotation.
- src/poetry/utils/env/env_manager.py:96:44: RUF036 `None` not at the end of the type annotation.

... Truncated remaining completed project reports due to GitHub comment length restrictions

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
RUF036 786 0 0 786 0

Copy link
Contributor

github-actions bot commented Jan 5, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@MichaReiser MichaReiser added the ci Related to internal CI tooling label Jan 6, 2025
@MichaReiser
Copy link
Member

MichaReiser commented Jan 6, 2025

Thanks.

I patched the ecosystem check locally to get a sense of how the violations change between not specifying no_fix and setting no_fix This is the output

ℹ️ ecosystem check detected linter changes. (+20 -0 violations, +0 -0 fixes in 3 projects; 52 projects unchanged)

pandas-dev/pandas (+0 -0 violations, +0 -0 fixes)


python/typeshed (+20 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --no-preview --select E,F,FA,I,PYI,RUF,UP,W

+ stdlib/argparse.pyi:395:63: PYI011 [*] Only simple default values allowed for typed arguments
+ stdlib/argparse.pyi:396:48: PYI011 [*] Only simple default values allowed for typed arguments
+ stdlib/argparse.pyi:399:57: PYI011 [*] Only simple default values allowed for typed arguments
+ stdlib/argparse.pyi:420:63: PYI011 [*] Only simple default values allowed for typed arguments
+ stdlib/argparse.pyi:421:48: PYI011 [*] Only simple default values allowed for typed arguments
+ stdlib/argparse.pyi:424:57: PYI011 [*] Only simple default values allowed for typed arguments
+ stdlib/builtins.pyi:119:9: PYI029 [*] Defining `__str__` in a stub is almost always redundant
+ stdlib/builtins.pyi:120:9: PYI029 [*] Defining `__repr__` in a stub is almost always redundant
+ stdlib/builtins.pyi:1687:1: PYI026 [*] Use `typing_extensions.TypeAlias` for type alias, e.g., `_SupportsSomeKindOfPow: TypeAlias = _SupportsPow2[Any, Any] | _SupportsPow3NoneOnly[Any, Any] | _SupportsPow3[Any, Any, Any]`
+ stdlib/builtins.pyi:229:1: PYI026 [*] Use `typing_extensions.TypeAlias` for type alias, e.g., `_LiteralInteger: TypeAlias = _PositiveInteger | _NegativeInteger | Literal[0]`
+ stdlib/distutils/version.pyi:26:9: PYI029 [*] Defining `__str__` in a stub is almost always redundant
+ stdlib/distutils/version.pyi:35:9: PYI029 [*] Defining `__str__` in a stub is almost always redundant
+ stubs/jsonschema/jsonschema/exceptions.pyi:32:34: PYI011 [*] Only simple default values allowed for typed arguments
+ stubs/jsonschema/jsonschema/exceptions.pyi:36:40: PYI011 [*] Only simple default values allowed for typed arguments
+ stubs/jsonschema/jsonschema/exceptions.pyi:37:33: PYI011 [*] Only simple default values allowed for typed arguments
+ stubs/jsonschema/jsonschema/exceptions.pyi:38:52: PYI011 [*] Only simple default values allowed for typed arguments
+ stubs/jsonschema/jsonschema/exceptions.pyi:41:45: PYI011 [*] Only simple default values allowed for typed arguments
+ stubs/olefile/olefile/olefile.pyi:187:37: PYI011 [*] Only simple default values allowed for typed arguments
+ stubs/olefile/olefile/olefile.pyi:193:82: PYI011 [*] Only simple default values allowed for typed arguments
+ stubs/tensorflow/tensorflow/autodiff.pyi:16:81: PYI011 [*] Only simple default values allowed for typed arguments

python-trio/trio (+0 -0 violations, +0 -0 fixes)


Changes by rule (3 rules affected)

code total + violation - violation + fix - fix
PYI011 14 14 0 0 0
PYI029 4 4 0 0 0
PYI026 2 2 0 0 0

Index: python/ruff-ecosystem/ruff_ecosystem/check.py
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/python/ruff-ecosystem/ruff_ecosystem/check.py b/python/ruff-ecosystem/ruff_ecosystem/check.py
--- a/python/ruff-ecosystem/ruff_ecosystem/check.py	(revision e5270e2ac2beada3ab141c66fa465dd6d115d8ae)
+++ b/python/ruff-ecosystem/ruff_ecosystem/check.py	(date 1736155061054)
@@ -515,6 +515,9 @@
                     options=options,
                 ),
             )
+            import dataclasses
+            options = dataclasses.replace(options, no_fix=True)
+
             comparison_task = tg.create_task(
                 ruff_check(
                     executable=ruff_comparison_executable.resolve(),
Index: python/ruff-ecosystem/ruff_ecosystem/projects.py
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/python/ruff-ecosystem/ruff_ecosystem/projects.py b/python/ruff-ecosystem/ruff_ecosystem/projects.py
--- a/python/ruff-ecosystem/ruff_ecosystem/projects.py	(revision e5270e2ac2beada3ab141c66fa465dd6d115d8ae)
+++ b/python/ruff-ecosystem/ruff_ecosystem/projects.py	(date 1736154397660)
@@ -198,6 +198,8 @@
     # Generating fixes is slow and verbose
     show_fixes: bool = False
 
+    no_fix: bool = False
+
     # Limit the number of reported lines per rule
     max_lines_per_rule: int | None = 50
 
@@ -222,6 +224,8 @@
             args.extend(["--exclude", self.exclude])
         if self.show_fixes:
             args.extend(["--show-fixes"])
+        if self.no_fix:
+            args.extend(["--no-fix"])
         return args
 
 

@MichaReiser MichaReiser merged commit bafe871 into astral-sh:main Jan 6, 2025
21 checks passed
dcreager added a commit that referenced this pull request Jan 6, 2025
* main: (60 commits)
  [`ruff`] Dataclass enums (`RUF049`) (#15299)
  Better error message when `--config` is given a table key and a non-inline-table value (#15266)
  Update pre-commit dependencies (#15289)
  Don't fix in ecosystem check (#15267)
  Update Rust crate itertools to 0.14.0 (#15287)
  Remove accidental empty block at the bottom of `split-static-string (SIM905)` doc (#15290)
  Update Rust crate clearscreen to v4 (#15288)
  Update Rust crate insta to v1.42.0 (#15286)
  Update NPM Development dependencies (#15285)
  Update dependency uuid to v11.0.4 (#15284)
  Update dependency ruff to v0.8.6 (#15283)
  Update Rust crate syn to v2.0.95 (#15282)
  Update Rust crate matchit to v0.8.6 (#15281)
  Update Rust crate bstr to v1.11.3 (#15280)
  [red-knot] Future-proof `Type::is_disjoint_from()` (#15262)
  [red-knot] Improve `Type::is_disjoint_from()` for `KnownInstanceType`s (#15261)
  [red-knot] Minor simplifications and improvements to constraint narrowing logic (#15270)
  Allow assigning ellipsis literal as parameter default value (#14982)
  [red-knot] fix control flow for assignment expressions in elif tests (#15274)
  [`refurb`] Mark fix as unsafe when the right-hand side is a string (`FURB171`) (#15273)
  ...
dcreager added a commit that referenced this pull request Jan 6, 2025
* main: (29 commits)
  [`ruff`] Dataclass enums (`RUF049`) (#15299)
  Better error message when `--config` is given a table key and a non-inline-table value (#15266)
  Update pre-commit dependencies (#15289)
  Don't fix in ecosystem check (#15267)
  Update Rust crate itertools to 0.14.0 (#15287)
  Remove accidental empty block at the bottom of `split-static-string (SIM905)` doc (#15290)
  Update Rust crate clearscreen to v4 (#15288)
  Update Rust crate insta to v1.42.0 (#15286)
  Update NPM Development dependencies (#15285)
  Update dependency uuid to v11.0.4 (#15284)
  Update dependency ruff to v0.8.6 (#15283)
  Update Rust crate syn to v2.0.95 (#15282)
  Update Rust crate matchit to v0.8.6 (#15281)
  Update Rust crate bstr to v1.11.3 (#15280)
  [red-knot] Future-proof `Type::is_disjoint_from()` (#15262)
  [red-knot] Improve `Type::is_disjoint_from()` for `KnownInstanceType`s (#15261)
  [red-knot] Minor simplifications and improvements to constraint narrowing logic (#15270)
  Allow assigning ellipsis literal as parameter default value (#14982)
  [red-knot] fix control flow for assignment expressions in elif tests (#15274)
  [`refurb`] Mark fix as unsafe when the right-hand side is a string (`FURB171`) (#15273)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to internal CI tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ecosystem check: Set --no-fix
2 participants