Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pyupgrade] Handle comments and multiline expressions correctly (UP037) #15337

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[pyupgrade] Handle comments and multiline expressions correctly (UP037) #15337

wants to merge 5 commits into from
+256 −9

Conversation

InSyncWithFoo
Copy link
Contributor

Summary

Resolves #7102.

Test Plan

cargo nextest run and cargo insta test.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

MichaReiser
MichaReiser reviewed Jan 8, 2025
View reviewed changes
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet

crates/ruff_linter/src/rules/pyupgrade/rules/quoted_annotation.rs Outdated Show resolved Hide resolved
..._linter/src/rules/pyupgrade/snapshots/ruff_linter__rules__pyupgrade__tests__UP037_2.pyi.snap Show resolved Hide resolved
crates/ruff_linter/src/rules/pyupgrade/rules/quoted_annotation.rs Outdated Show resolved Hide resolved
@MichaReiser MichaReiser added the fixes Related to suggested fixes for violations label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaReiser MichaReiser MichaReiser left review comments

Assignees
No one assigned
Labels
fixes Related to suggested fixes for violations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rules UP037 cause autofix error
2 participants
@InSyncWithFoo @MichaReiser