Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[red-knot] Property test workflow: Fix issue label, link to CI run #15361

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

sharkdp
Copy link
Contributor

@sharkdp sharkdp commented Jan 8, 2025

Summary

See title. Had to make a minor change, because it failed the zizmor pre-commit check otherwise (FYI @AlexWaygood)

error[template-injection]: code injection via template expansion
  --> /home/shark/ruff/.github/workflows/daily_fuzz.yaml:68:9
   |
68 |          - uses: actions/github-script@v7
   |  __________^
69 | |          with:
70 | |            github-token: ${{ secrets.GITHUB_TOKEN }}
71 | |            script: |
   | | ___________^
72 | ||             await github.rest.issues.create({
...  ||
77 | ||               labels: ["bug", "parser", "fuzzer"],
78 | ||             })
   | ||               ^
   | ||_______________|
   |  |_______________this step
   |                  github.server_url may expand into attacker-controllable code
   |
   = note: audit confidence → High

@sharkdp sharkdp added testing Related to testing Ruff itself red-knot Multi-file analysis & type inference labels Jan 8, 2025
@AlexWaygood
Copy link
Member

AlexWaygood commented Jan 8, 2025

See title. Had to make a minor change, because it failed the zizmor pre-commit check otherwise (FYI @AlexWaygood)

Ooh interesting. @woodruffw could that context field really be controlled by an attacker...? That feels like it might be a false positive to me? :-)

(Docs here)

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! Hardcoding github.com seems very unlikely to break, whether or not the zizmor diagnostic is a false positive 😄

@sharkdp sharkdp merged commit b6562ed into main Jan 8, 2025
25 checks passed
@sharkdp sharkdp deleted the david/property-test-updates-fix branch January 8, 2025 21:47
@woodruffw
Copy link

Ooh interesting. @woodruffw could that context field really be controlled by an attacker...? That feels like it might be a false positive to me? :-)

Yep, that looks like a false positive! Thanks for the ping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
red-knot Multi-file analysis & type inference testing Related to testing Ruff itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants