Add dependency-group cli flags to `uv pip install` and `uv pip compile` (`--group`, `--no-group`, `--only-group`, `--all-groups`) #10861

Gankra · 2025-01-22T14:55:18Z

Ultimately this is a lot of settings plumbing and a couple minor pieces of Actual Logic (which are so simple I have to assume there's something missing, but maybe not!).

Note this "needlessly" use DevDependencyGroup since it costs nothing, is more futureproof, and lets us maintain one primary interface (we just pass false for all the dev arguments).

Fixes #8590
Fixes #8969

Gankra · 2025-01-22T14:57:40Z

No description provided.

Gankra · 2025-01-22T15:06:53Z

crates/uv-settings/src/settings.rs

+    /// Include optional dependencies from the specified group; may be provided more than once.
+    ///
+    /// Only applies to `pyproject.toml`, `setup.py`, and `setup.cfg` sources.
+    #[option(
+        default = "[]",
+        value_type = "list[str]",
+        example = r#"
+            group = ["dev", "docs"]
+        "#
+    )]
+    pub group: Option<Vec<GroupName>>,


Whether these were supposed to pass through the shared PipOptions and not a side-thing was an uncertainty for me. Overall I assumed they're equivalentish to the extra settings and those are here, so, seems fine?

Seems right to me, though the option abstractions are not my forte.

crates/uv-cli/src/lib.rs

zanieb · 2025-01-22T17:05:00Z

crates/uv-configuration/src/dev.rs

+    /// Returns `true` if the specification will have no effect.
+    pub fn is_empty(&self) -> bool {
+        let GroupsSpecification::Include {
+            include: IncludeGroups::Some(includes),
+            exclude,
+        } = self
+        else {
+            return false;
+        };
+        includes.is_empty() && exclude.is_empty()
+    }
 }


I'm not entirely sure about the correctness of this. Is this relying on some assumptions about the construction of GroupsSpecification?

It is, but it's a relatively mundane assumption imo.

Might be worth a comment saying what the assumption is, but don't feel strongly.

crates/uv-requirements/src/sources.rs

zanieb · 2025-01-22T17:07:28Z

crates/uv-settings/src/settings.rs

+    /// Include optional dependencies from the specified group; may be provided more than once.
+    ///
+    /// Only applies to `pyproject.toml`, `setup.py`, and `setup.cfg` sources.
+    #[option(
+        default = "[]",
+        value_type = "list[str]",
+        example = r#"
+            group = ["dev", "docs"]
+        "#
+    )]
+    pub group: Option<Vec<GroupName>>,


Seems right to me, though the option abstractions are not my forte.

zanieb · 2025-01-22T17:10:05Z

crates/uv/tests/it/pip_install.rs

@@ -8257,3 +8257,161 @@ fn cyclic_build_dependency() {
    "###
    );
 }
+
+#[test]
+fn install_group() -> Result<()> {


What happens if multiple pyproject.toml files are provided? What happens if a group is present in one but not the other? If a group is present in both?

Similarly, what about uv pip install <dir> --group <name>?

I believe as currently implemented we:

don't complain if we fail to find a group in the toml

would independently match and include groups from every toml

This falls out of the implementation basically being "for each sourcefile, for each group in that sourcefile, if the selector built from cli flags matches the name of this group, append that group to the requirements".

not sure about the dir usecase

I think we should fail (or at the very least, warn) if we cannot find a group.

I don't mind including groups from every toml, but we should have test coverage.

We fail in uv sync fwiw

❯ uv sync --group test error: Group `test` is not defined in the project's `dependency-group` table

Added warnings.

zanieb · 2025-01-22T17:13:24Z

docs/reference/settings.md

+#### [`all-groups`](#pip_all-groups) {: #pip_all-groups }
+<span id="all-groups"></span>
+
+Include all groups.
+
+Only applies to `pyproject.toml`, `setup.py`, and `setup.cfg` sources.
+
+**Default value**: `false`
+
+**Type**: `bool`
+
+**Example usage**:
+
+=== "pyproject.toml"
+
+    ```toml
+    [tool.uv.pip]
+    all-groups = true
+    ```
+=== "uv.toml"
+
+    ```toml
+    [pip]
+    all-groups = true
+    ```
+
+---
+


Honestly I'm not sure why we support requesting extras in settings file like this. It seems correct to match the extras options for groups though?

Perhaps @charliermarsh understands the use-case?

qvalentin · 2025-01-23T14:12:09Z

Thanks @Gankra

henryiii · 2025-01-23T16:54:26Z

Not that this is does not match the proposed API for pip, so pip and uv pip would diverge. pypa/pip#13065 is going to be merged soon.

Gankra · 2025-01-23T17:06:38Z

Wow incredible timing. This won't get released in uv until we're happy with our interop story (will back this out if need be).

zanieb · 2025-01-23T17:08:10Z

This is intended to be compatible with the proposed pip interface, i.e., we can implement it once it's released. We have to deal with a bit more complexity because we allow -r pyproject.toml which pip has said they will not support.

Filimoa · 2025-01-31T15:19:19Z

Is there another way of compiling development groups dependencies into a requirements.txt if this is no longer planned? I don't see anything in the docs or issues so just wondering if it's possible.

charliermarsh · 2025-01-31T15:24:19Z

If you use uv lock, you can then uv export into a requirements.txt today. (We still plan to ship this, we just deferred it for a bit.)

henryiii · 2025-01-31T15:51:13Z

And pypa/pip#13065 should be about ready to go in, it's already got an approval. You can also use uvx dependency-groups > requirements.txt if you want them unlocked.

Gankra commented Jan 22, 2025

View reviewed changes

zanieb reviewed Jan 22, 2025

View reviewed changes

Gankra added 9 commits January 22, 2025 13:48

WIP: it works?

d39a562

add positive pip_install --group tests

25167a5

add no_default_groups

d5af9f8

generate-all

915e8e6

restrict to pyproject.tomls

1235604

don't support --no-default-groups

9022093

fix ordering of doc comment

b02b04b

regen snapshots

3ce6e53

regen more snapshots

15e22dc

Gankra force-pushed the gankra/depgroups branch from 264867c to 15e22dc Compare January 22, 2025 18:52

Gankra added 3 commits January 22, 2025 13:53

omg clippy chill

cd13972

fix

ccc1d71

add tests for multi-install

9247f2f

Gankra mentioned this pull request Jan 22, 2025

feat: error on non-existent extra #10869

Open

Gankra added 3 commits January 22, 2025 15:34

Add warnings for undefined groups

510c5f0

add tests for pip_compile

a1e3b53

stabilize output

3d043f1

Gankra merged commit 53706a1 into main Jan 23, 2025
68 checks passed

Gankra deleted the gankra/depgroups branch January 23, 2025 13:47

cthoyt mentioned this pull request Jan 23, 2025

Implement dependency groups cthoyt/cookiecutter-snekpack#32

Draft

notatallshaw mentioned this pull request Jan 23, 2025

Feature Proposal: PEP 735 "Dependency Groups" Support pypa/pip#12963

Open

1 task

zanieb mentioned this pull request Jan 23, 2025

temporarily disable new uv pip dependency-group flags #10909

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add dependency-group cli flags to `uv pip install` and `uv pip compile` (`--group`, `--no-group`, `--only-group`, `--all-groups`) #10861

Add dependency-group cli flags to `uv pip install` and `uv pip compile` (`--group`, `--no-group`, `--only-group`, `--all-groups`) #10861

Gankra commented Jan 22, 2025 •

edited

Loading

Gankra commented Jan 22, 2025 •

edited

Loading

Gankra Jan 22, 2025

zanieb Jan 22, 2025

zanieb Jan 22, 2025

Gankra Jan 22, 2025

zanieb Jan 22, 2025

zanieb Jan 22, 2025

zanieb Jan 22, 2025

zanieb Jan 22, 2025

Gankra Jan 22, 2025

zanieb Jan 22, 2025

zanieb Jan 22, 2025

Gankra Jan 22, 2025

zanieb Jan 22, 2025

qvalentin commented Jan 23, 2025

henryiii commented Jan 23, 2025

Gankra commented Jan 23, 2025

zanieb commented Jan 23, 2025

Filimoa commented Jan 31, 2025

charliermarsh commented Jan 31, 2025

henryiii commented Jan 31, 2025

Add dependency-group cli flags to uv pip install and uv pip compile (--group, --no-group, --only-group, --all-groups) #10861

Add dependency-group cli flags to uv pip install and uv pip compile (--group, --no-group, --only-group, --all-groups) #10861

Conversation

Gankra commented Jan 22, 2025 • edited Loading

Gankra commented Jan 22, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qvalentin commented Jan 23, 2025

henryiii commented Jan 23, 2025

Gankra commented Jan 23, 2025

zanieb commented Jan 23, 2025

Filimoa commented Jan 31, 2025

charliermarsh commented Jan 31, 2025

henryiii commented Jan 31, 2025

Add dependency-group cli flags to `uv pip install` and `uv pip compile` (`--group`, `--no-group`, `--only-group`, `--all-groups`) #10861

Add dependency-group cli flags to `uv pip install` and `uv pip compile` (`--group`, `--no-group`, `--only-group`, `--all-groups`) #10861

Gankra commented Jan 22, 2025 •

edited

Loading

Gankra commented Jan 22, 2025 •

edited

Loading