-
Notifications
You must be signed in to change notification settings - Fork 86
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(sequencer): implement market endpoint (#1946)
## Summary This is a small PR to address a couple of minor omissions: implementing a query endpoint, and removing a needless RPC call. ## Background These are likely just small omissions from previous work/discussions. ## Changes - Updated `MarketMapQueryService::market` to not always return a "not implemented" error response. - Changed initial connection attempts to oracle sidecar to not actually send a request. ## Testing Manually tested both changes locally. The former would ideally have unit tests, but this entire module is not unit tested. The latter is harder to create a meaningful unit test for, but new smoke tests using the sidecar will make it apparent if this function is broken. ## Changelogs No updates required.
- Loading branch information
Showing
2 changed files
with
25 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters