Skip to content

Commit

Permalink
fix: ignore RUSTSEC-2021-0139 (#1171)
Browse files Browse the repository at this point in the history
## Summary
Ignore RustSec warning.

## Background
We get a non-critical warning when running `cargo audit`:
[RUSTSEC-2021-0139](https://rustsec.org/advisories/RUSTSEC-2021-0139).

When running `cargo tree -i -p=ansi_term` we can see that `ansi_term` is
a dependency of `dylint` and `tracing-subscriber` v0.2. While
`tracing-subscriber` v0.3 doesn't depend upon `ansi_term`, we can't
easily upgrade to that version as several of our dependencies do not
support v0.3. Also, `dylint`'s latest version still depends upon
`ansi_term`.

Given that the RustSec report doesn't suggest any concrete problems with
`ansi_term` and how difficult it will be to move away from this
dependency, I have just ignored this warning in CI.

We also have a further audit warning about v0.1.29 of `jobserver` being
yanked, so I have updated that dependency.

## Changes
- Ignore RustSec warning in newly-added `.cargo/audit.toml` file.

## Testing
CI and ran `cargo audit` locally.

## Related Issues
Closes #914.
  • Loading branch information
Fraser999 authored Jun 10, 2024
1 parent 381d798 commit 684fd74
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
4 changes: 4 additions & 0 deletions .cargo/audit.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
[advisories]
# RUSTSEC-2021-0139: `ansi_term` is Unmaintained. It is a transient dependency of penumbra crates
# and dylint, so cannot easily be replaced.
ignore = ["RUSTSEC-2021-0139"]
1 change: 1 addition & 0 deletions .github/workflows/reusable-docker-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ jobs:
- uses: actions/checkout@v4
with:
ref: ${{ inputs.tag }}
submodules: 'true'
- uses: depot/setup-action@v1
- name: Login to Docker Hub
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == 'astriaorg/astria'
Expand Down
4 changes: 2 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 684fd74

Please sign in to comment.