fix(sequencer)!: fix block fees (#1343)

## Summary Corrected block fee reporting so that proposer is paid the correct fees. ## Background Previously, only `TransferAction` and `SequenceAction` called `get_and_increase_block_fees()`, the method for increasing the running fees for the block. In `end_block`, this was used for calculating how much to increase the proposer's balance meaning that they were only paid the fees for `Transfer` and `Sequence` actions. ## Changes - Implemented `get_and_increase_block_fees()` in all actions which charge fees. ## Testing Added unit tests for each action, with the exception of `Ics20Withdrawal`. This test should be implemented, but will require a more in-depth configuration. ## Breaking Changelist - App hash changed, snapshot has been regenerated. ## Related Issues closes #1333 --------- Co-authored-by: Richard Janis Goldschmidt <[email protected]> Co-authored-by: Fraser Hutchison <[email protected]> Co-authored-by: noot <[email protected]>
astriaorg · Aug 21, 2024 · 781c4c5 · 781c4c5
1 parent 1f4a359
commit 781c4c5
Show file tree

Hide file tree

Showing 9 changed files with 403 additions and 89 deletions.
diff --git a/crates/astria-sequencer/src/accounts/action.rs b/crates/astria-sequencer/src/accounts/action.rs
@@ -5,7 +5,7 @@ use anyhow::{
 };
 use astria_core::{
     protocol::transaction::v1alpha1::action::TransferAction,
-    Protobuf,
+    Protobuf as _,
 };
 use cnidarium::{
     StateRead,

diff --git a/crates/astria-sequencer/src/app/mod.rs b/crates/astria-sequencer/src/app/mod.rs
@@ -5,6 +5,8 @@ pub(crate) mod test_utils;
 #[cfg(test)]
 mod tests_app;
 #[cfg(test)]
+mod tests_block_fees;
+#[cfg(test)]
 mod tests_breaking_changes;
 #[cfg(test)]
 mod tests_execute_transaction;

diff --git a/...snapshots/astria_sequencer__app__tests_breaking_changes__app_finalize_block_snapshot.snap b/...snapshots/astria_sequencer__app__tests_breaking_changes__app_finalize_block_snapshot.snap
@@ -3,36 +3,36 @@ source: crates/astria-sequencer/src/app/tests_breaking_changes.rs
 expression: app.app_hash.as_bytes()
 ---
 [
-  72,
-  87,
-  29,
-  138,
-  91,
-  221,
-  71,
+  36,
   66,
-  219,
-  212,
-  171,
-  126,
-  223,
-  176,
-  198,
-  154,
-  10,
-  234,
-  253,
-  99,
-  213,
-  78,
-  92,
-  228,
-  89,
-  204,
-  197,
+  30,
+  16,
+  122,
+  103,
+  62,
+  67,
+  145,
+  180,
+  247,
+  139,
+  229,
+  200,
+  86,
   193,
-  90,
-  57,
-  205,
-  2
+  28,
+  71,
+  235,
+  32,
+  134,
+  143,
+  239,
+  229,
+  8,
+  86,
+  190,
+  164,
+  81,
+  230,
+  24,
+  149
 ]
-Original file line number
+Diff line change
@@ Expand Up @@
     expression: app.app_hash.as_bytes()
     ---
     [
-,
-,
-,
-,
-,
-,
-,
+,
 ,
-,
-,
-,
-,
-,
-,
-,
-,
-,
-,
-,
-,
-,
-,
-,
-,
-,
-,
-,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
 ,
-,
-,
-,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
     ]