You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently have a mixture of hand-rolled encoders and usage of the hex crate.
We should check the performance of hex-conservative and use it exclusively throughout our codebase if it's performant enough, or if not, we should just avoid using any third-party crates for this and extend our own hand-rolled implementation to cover all our needs.
Ensure that when using this to display a byte array we make use of appropriate non-allocating functionality provided by hex-conservative crate.
We currently have a mixture of hand-rolled encoders and usage of the
hex
crate.We should check the performance of
hex-conservative
and use it exclusively throughout our codebase if it's performant enough, or if not, we should just avoid using any third-party crates for this and extend our own hand-rolled implementation to cover all our needs.Ensure that when using this to display a byte array we make use of appropriate non-allocating functionality provided by
hex-conservative
crate.Relevant code paths in this repo:
astria/crates/astria-telemetry/src/display.rs
Lines 59 to 79 in 4478cb6
astria/crates/astria-sequencer/src/utils.rs
Lines 16 to 25 in e945677
┆Issue Number: ENG-841
The text was updated successfully, but these errors were encountered: