chore(sequencer)!: put blocks and deposits to non-verified storage (ENG-812) #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fraser999
requested review from
a team,
joroshiba,
SuperFluffy and
noot
as code owners
Fraser999
changed the title
noot
reviewed
Sep 20, 2024
SuperFluffy
reviewed
Sep 23, 2024
SuperFluffy
reviewed
Sep 23, 2024
SuperFluffy
reviewed
Sep 23, 2024
noot
approved these changes
Sep 23, 2024
SuperFluffy
reviewed
Sep 23, 2024
There was a problem hiding this comment.
@noot Can I ask you to double check these keys? I think I recall (but might be mistaken) that you wanted plaintext/human readable keys.
I don't think we ever formalized this, but I would like you to give your explicit approval here.
SuperFluffy
reviewed
Sep 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
noot
reviewed
Sep 24, 2024
…n-verified-storage
bharath-123
pushed a commit
that referenced
this pull request
Sep 26, 2024
…NG-812) (#1525) ## Summary This changes where sequencer blocks and the `TracePrefixed` native asset are stored, and also persists `Deposit`s to non-verifiable storage. ## Background Sequencer blocks are currently written to verified storage, which is unnecessary as all of their constituent data is already available there. We want to avoid the cost of storing full blocks in verified storage, but still have the ability to provide a third party with a full block if requested. To further assist with this, deposits will also be written to non-verified storage. It also seemed appropriate to store the `TracePrefixed` native asset in verified storage, since this is something which all validators should reach consensus over. ## Changes - `SequencerBlock`s are now stored in non-verifiable storage. - `Deposit`s are now stored in non-verifiable storage. - The native asset is now stored in verifiable storage. ## Testing Existing unit tests have been updated as required to assert these changes. ## Breaking Changelist - The set of data being written to verified storage has changed, which is a breaking change in terms of on-disk data and generation of state root hashes. Otherwise no APIs have changed. ## Related Issues Closes #1493.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This changes where sequencer blocks and the
TracePrefixednative asset are stored, and also persistsDeposits to non-verifiable storage.Background
Sequencer blocks are currently written to verified storage, which is unnecessary as all of their constituent data is already available there.
We want to avoid the cost of storing full blocks in verified storage, but still have the ability to provide a third party with a full block if requested. To further assist with this, deposits will also be written to non-verified storage.
It also seemed appropriate to store the
TracePrefixednative asset in verified storage, since this is something which all validators should reach consensus over.Changes
SequencerBlocks are now stored in non-verifiable storage.Deposits are now stored in non-verifiable storage.Testing
Existing unit tests have been updated as required to assert these changes.
Breaking Changelist
Related Issues
Closes #1493.