Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(charts): update geth charts for oracle genesis values #1883

Merged
merged 9 commits into from
Jan 20, 2025

Conversation

noot
Copy link
Collaborator

@noot noot commented Dec 18, 2024

Summary

update geth charts for oracle genesis values.

Background

geth charts needed to be updated for the oracle integration; see astriaorg/astria-geth#62

Changes

  • add astriaOracleCallerAddress and astriaOracleContractAddress config values
  • add oracle contract bytecode to genesis alloc at astriaOracleContractAddress
  • update dev tags for geth and sequencer

Testing

ran it end-to-end with the usual dev cluster instructions and queried the oracle contract for price updates via the instructions here: https://github.com/astriaorg/astria-oracle-contracts/tree/main?tab=readme-ov-file#query-contract

@noot noot requested a review from a team as a code owner December 18, 2024 17:39
@noot noot requested a review from aajimal December 18, 2024 17:39
@github-actions github-actions bot added the cd label Dec 18, 2024
Copy link
Contributor

@quasystaty1 quasystaty1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one idea to move the images used into the value file as this is a temporarily change.

@@ -11,13 +11,13 @@ images:
repo: ghcr.io/astriaorg/astria-geth
pullPolicy: IfNotPresent
tag: 1.0.0
devTag: latest
devTag: sha-a9d1e6a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe should override devTag in dev/values/rollup/dev.yaml for clarity? Same for conductor and sequencer in its dev file.

@@ -159,7 +171,8 @@ config:
condition: .Values.metrics.enabled
- name: txpool.nolocals
value: "true"

- name: verbosity
value: "4" # 3=info, 4=debug
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@noot noot merged commit 0974c1f into feat/oracle Jan 20, 2025
45 checks passed
@noot noot deleted the noot/oracle-geth-tmp branch January 20, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants