-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(charts): update geth charts for oracle genesis values #1883
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one idea to move the images used into the value file as this is a temporarily change.
@@ -11,13 +11,13 @@ images: | |||
repo: ghcr.io/astriaorg/astria-geth | |||
pullPolicy: IfNotPresent | |||
tag: 1.0.0 | |||
devTag: latest | |||
devTag: sha-a9d1e6a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe should override devTag in dev/values/rollup/dev.yaml
for clarity? Same for conductor and sequencer in its dev file.
@@ -159,7 +171,8 @@ config: | |||
condition: .Values.metrics.enabled | |||
- name: txpool.nolocals | |||
value: "true" | |||
|
|||
- name: verbosity | |||
value: "4" # 3=info, 4=debug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Summary
update geth charts for oracle genesis values.
Background
geth charts needed to be updated for the oracle integration; see astriaorg/astria-geth#62
Changes
astriaOracleCallerAddress
andastriaOracleContractAddress
config valuesastriaOracleContractAddress
Testing
ran it end-to-end with the usual dev cluster instructions and queried the oracle contract for price updates via the instructions here: https://github.com/astriaorg/astria-oracle-contracts/tree/main?tab=readme-ov-file#query-contract