Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Minor clean ups in unit-tests #2

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: Minor clean ups in unit-tests #2

wants to merge 2 commits into from

Conversation

bharath-123
Copy link
Collaborator

The PR contains the following changes:

  1. The unit-tests of the Execution API hard codes the status.Ok success code as 0. It is more readable to use the enum status.Ok
  2. Add assertions for the returned error being nil, if the expected status code is not status.Ok to make the unit-tests stronger.
  3. Remove some un-used code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joroshiba joroshiba Awaiting requested review from joroshiba joroshiba is a code owner

@mycodecrafting mycodecrafting Awaiting requested review from mycodecrafting mycodecrafting is a code owner

@noot noot Awaiting requested review from noot noot is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bharath-123