Fix failing test_transform_forward_healpix_iter test
#258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forces generated flm to always correspond to real signal. Increases minimum number of iterations as test for round trip error bring within tolerance sensitive to specific random draws for smaller number of iterations.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #258 +/- ##
==========================================
+ Coverage 96.21% 96.28% +0.07%
==========================================
Files 32 32
Lines 3591 3606 +15
==========================================
+ Hits 3455 3472 +17
+ Misses 136 134 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately recent merges seemed to have caused
test_transform_forward_healpix_itertest intests/test_spherical_base.pyto begin failing for some parameter combinations (specifically whenn_iter = 7). Looking at the failures I think these are spurious as the round-trip errors reported are still very small, but just not within the specified error tolerance, and they consistently are within the tolerance for the largern_iter = 10tested. I think this just an artefact of #252 having changed the specificflmvalues that will be generated (as the vectorized function draws variates in a different order) and I having chose the minimum number of iterations to test to be too small for the tolerance being checked. Slightly increasing the number of iterations ton_iter = 8fixes. I also noticed that we were testing withrealityparametrized to bothTrueandFalse, but as I think thehealpyfunctions assume the signal is always real, I've reduced to just fixingreality = Truehere.