Skip to content
This repository has been archived by the owner on Jul 3, 2024. It is now read-only.

50 - Solidity Linter rules #138

Merged
merged 116 commits into from
Oct 9, 2023
Merged

50 - Solidity Linter rules #138

merged 116 commits into from
Oct 9, 2023

Conversation

github-actions[bot]
Copy link

Solves #50

@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules-staging branch 3 times, most recently from ea96ece to 9510554 Compare October 3, 2023 15:08
Astrodevs CI and others added 27 commits October 7, 2023 15:27
@0xmemorygrinder
chore: create branch feature/50-solidity-linter-rules-staging
6aa1817
@0xmemorygrinder
chore: create branch feature/50-solidity-linter-rules/106-one-contrac…
05a112b 
…t-per-file-rule-staging
@ByFishh @0xmemorygrinder
feat(solidity/linter/core): OneContractPerFile rule
1c74958
@0xmemorygrinder
chore: create branch feature/50-solidity-linter-rules/119-no-inline-a…
7469c32 
…ssembly-rule-staging
@0xtekgrinder @0xmemorygrinder
feat(solidity/linter/core): NoInlineAssembly Rule
8ff6b63
@0xtekgrinder @0xmemorygrinder
tests: functionMaxLines test works
4370fcf
@0xmemorygrinder
chore: deleted remove-me
8d5c842
@0xmemorygrinder
chore: create branch feature/50-solidity-linter-rules/117-func-visibi…
4aff782 
…lity-rule-staging
@ByFishh @0xmemorygrinder
feat(solidity/linter/core): FuncVisibility rule
0c95f52
@0xmemorygrinder
chore: deleted remove-me
6410efe
@0xtekgrinder @0xmemorygrinder
feat(ast-extractor): add stmts retriever
c258dd4
@0xtekgrinder @0xmemorygrinder
feat(solidity/linter/core): apply stmts retriever to NoInlineAssembly
027262a
@0xmemorygrinder
chore: create branch feature/50-solidity-linter-rules/98-custom-error…
01d66b0 
…s-rule-staging
@0xtekgrinder @0xmemorygrinder
feat(solidity/linter/core): add CustomErrors Rule
32dd7f5
@0xtekgrinder @0xmemorygrinder
chore: remove remove-me file
e9adb17
@ByFishh @0xmemorygrinder
feat(solidity/linter/core): add removeme
26b8435
@0xmemorygrinder
chore: create branch feature/50-solidity-linter-rules/108-event-name-…
e0ad4dd 
…camelcase-rule-staging
@ByFishh @0xmemorygrinder
feat(solidity/linter/core): EventNameCamelCase rule
5a3bc8a
@0xmemorygrinder
chore: deleted remove-me
9662675
@ByFishh @0xmemorygrinder
feat(solidity/linter/core): add counter test
f861e6e
@0xmemorygrinder
chore: create branch feature/50-solidity-linter-rules/107-const-name-…
e6f9c8c 
…snakecase-rule-staging
@ByFishh @0xmemorygrinder
feat(solidity/linter/core): ConstNameSnakeCase rule
b84a928
@ByFishh @0xmemorygrinder
feat(solidity/linter/core): edit return syntax
ffec0d6
@ByFishh @0xmemorygrinder
feat(solidity/linter/core): use if instead of match
2af4261
@0xmemorygrinder
chore: deleted remove-me
320417f
@ByFishh @0xmemorygrinder
feat(solidity/linter/core): add counter test
514b56d
@0xmemorygrinder
chore: create branch feature/50-solidity-linter-rules/120-state-visib…
5f66ff7 
…ility-rule-staging
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules-staging branch from fe0a5fc to cd432d0 Compare October 9, 2023 20:36
0xmemorygrinder and others added 17 commits October 9, 2023 16:36
@0xmemorygrinder
feat(solidity/linter/core): ordering rule
c67f21c
@0xmemorygrinder
chore: create branch feature/50-solidity-linter-rules/116-foundry-tes…
e2965bc 
…t-functions-rule-staging
@0xmemorygrinder
feat(solidity/linter/rule): added foundry teest function name rule
2e9ff02
@0xmemorygrinder
fix(solidity/linter/core): run rule only on files ending by .t.sol
9c9e75d
@0xmemorygrinder
chore: delete remove-me
6b0cf28
@0xmemorygrinder
feat(solidity/linter/core): added exclusion data in foundry test func…
5f5bbb8 
… name rule
@0xmemorygrinder
fix(solidity/linter/core): now run foundry naming rule on public and …
70fa9b5 
…external functions only
@0xmemorygrinder
merge: PR #166 from feature/50-solidity-linter-rules/116-foundry-test…
37dc7f5 
…-functions-rule-staging

116 - Foundry Test Functions Rule
@0xtekgrinder
chore(solidity/linter/core): check for fmt errors
b4cfa25
@0xSwapFeeder
chore: create branch feature/50-solidity-linter-rules/112-private-var…
c187b33 
…s-leading-underscore-rule-staging
@0xtekgrinder @0xSwapFeeder
feat(solidity/linter/core): store json value in data to have more fle…
3b10879 
…xibility
@0xmemorygrinder @0xSwapFeeder
feat(solidity/linter/core): PrivateVarsLeadingUnderscore rule
0f48df2
@ByFishh @0xSwapFeeder
feat(solidity/linter/core): add rule strict mode
7d6b287
@ByFishh @0xSwapFeeder
feat(solidity/linter/core): delete removeme file
a1ab585
@0xSwapFeeder
fix(solidity/linter/core): fixed tests with new config format
b4da7b9
@0xSwapFeeder
fix(solidity/lint/core): fixed lint and compile issues
de513d0
@0xtekgrinder @0xSwapFeeder
merge: #145 from feature/50-solidity-linter-rules/112-private-vars-le…
0a888aa 
…ading-underscore-rule-staging

112 - Private Vars Leading Underscore Rule
@0xSwapFeeder 0xSwapFeeder force-pushed the feature/50-solidity-linter-rules-staging branch from b5eb6a5 to 0a888aa Compare October 9, 2023 21:18
@0xtekgrinder 0xtekgrinder marked this pull request as ready for review October 9, 2023 21:19
0xtekgrinder
0xtekgrinder approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@0xtekgrinder 0xtekgrinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

EnergyCube
EnergyCube approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@EnergyCube EnergyCube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xtekgrinder 0xtekgrinder merged commit 8784b43 into dev Oct 9, 2023
14 checks passed
@0xmemorygrinder 0xmemorygrinder deleted the feature/50-solidity-linter-rules-staging branch October 11, 2023 15:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@0xtekgrinder 0xtekgrinder 0xtekgrinder approved these changes

@0xmemorygrinder 0xmemorygrinder 0xmemorygrinder approved these changes

@EnergyCube EnergyCube EnergyCube approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Project Management
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@EnergyCube @0xmemorygrinder @0xtekgrinder @ByFishh @0xSwapFeeder @Leon-azerty