Skip to content
This repository has been archived by the owner on Jul 3, 2024. It is now read-only.

102 - No Global Import Rule #146

Merged
merged 3 commits into from
Oct 9, 2023
Merged

102 - No Global Import Rule #146

merged 3 commits into from
Oct 9, 2023

Conversation

github-actions[bot]
Copy link

Solves #102

@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules-staging branch from 36d6706 to 09fcef1 Compare September 30, 2023 17:20
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules/102-no-global-import-rule-staging branch from 6d82ad5 to 205a337 Compare September 30, 2023 17:24
@Leon-azerty Leon-azerty marked this pull request as ready for review October 2, 2023 13:50
@Leon-azerty Leon-azerty self-assigned this Oct 2, 2023
0xtekgrinder
0xtekgrinder suggested changes Oct 3, 2023
View reviewed changes
Copy link
Member

@0xtekgrinder 0xtekgrinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add a counter test to be sure that it doesn't detect global import and use the ask instead of parsing lines to check attributes of the files directly

@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules-staging branch from ea96ece to 9510554 Compare October 3, 2023 15:08
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules/102-no-global-import-rule-staging branch 2 times, most recently from 61486ec to 58d63f8 Compare October 3, 2023 23:54
0xtekgrinder
0xtekgrinder approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@0xtekgrinder 0xtekgrinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules-staging branch from 662f9c5 to f3cf5fe Compare October 7, 2023 19:27
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules/102-no-global-import-rule-staging branch from 965a1aa to 27cec17 Compare October 7, 2023 22:35
@0xmemorygrinder 0xmemorygrinder self-assigned this Oct 8, 2023
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules/102-no-global-import-rule-staging branch from 27cec17 to 16abfbe Compare October 8, 2023 19:53
@0xSwapFeeder 0xSwapFeeder force-pushed the feature/50-solidity-linter-rules/102-no-global-import-rule-staging branch from 16abfbe to d8e996b Compare October 8, 2023 21:34
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules/102-no-global-import-rule-staging branch 4 times, most recently from dc17534 to 7123530 Compare October 8, 2023 23:03
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules-staging branch 2 times, most recently from 03b3702 to ba700c1 Compare October 9, 2023 00:49
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules/102-no-global-import-rule-staging branch from 7123530 to 83363c6 Compare October 9, 2023 00:54
@0xmemorygrinder 0xmemorygrinder merged commit 417e9b5 into feature/50-solidity-linter-rules-staging Oct 9, 2023
6 checks passed
@0xmemorygrinder 0xmemorygrinder deleted the feature/50-solidity-linter-rules/102-no-global-import-rule-staging branch October 9, 2023 00:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@0xtekgrinder 0xtekgrinder 0xtekgrinder approved these changes

@0xmemorygrinder 0xmemorygrinder 0xmemorygrinder approved these changes

Assignees

@0xmemorygrinder 0xmemorygrinder

@Leon-azerty Leon-azerty

Labels
None yet
Projects
Project Management
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xmemorygrinder @0xtekgrinder @Leon-azerty