Skip to content
This repository has been archived by the owner on Jul 3, 2024. It is now read-only.

105 - Payable Fallback Rule #147

Merged
merged 11 commits into from
Oct 9, 2023
Merged

105 - Payable Fallback Rule #147

merged 11 commits into from
Oct 9, 2023

Conversation

github-actions[bot]
Copy link

Solves #105

@0xtekgrinder 0xtekgrinder self-requested a review September 29, 2023 19:17
@0xtekgrinder 0xtekgrinder self-assigned this Sep 29, 2023
@0xtekgrinder 0xtekgrinder marked this pull request as ready for review September 29, 2023 19:17
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules-staging branch from 36d6706 to 09fcef1 Compare September 30, 2023 17:20
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules/105-payable-fallback-rule-staging branch from 6d14c84 to ff5a534 Compare September 30, 2023 17:25
0xtekgrinder
0xtekgrinder suggested changes Oct 2, 2023
View reviewed changes
Copy link
Member

@0xtekgrinder 0xtekgrinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to refactor this rule to be based on the AST and not the content so iterating over every functions, finding the fallback and checking their attributes to be sure she is payable.

ps: you also have extra remove-me files

@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules-staging branch from ea96ece to 9510554 Compare October 3, 2023 15:08
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules/105-payable-fallback-rule-staging branch 2 times, most recently from 56241e7 to b9b0b93 Compare October 3, 2023 23:52
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules-staging branch from 662f9c5 to f3cf5fe Compare October 7, 2023 19:27
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules/105-payable-fallback-rule-staging branch from c76846d to b22b7fe Compare October 7, 2023 22:31
@0xtekgrinder 0xtekgrinder self-requested a review October 8, 2023 20:07
0xtekgrinder
0xtekgrinder approved these changes Oct 8, 2023
View reviewed changes
Copy link
Member

@0xtekgrinder 0xtekgrinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xSwapFeeder 0xSwapFeeder force-pushed the feature/50-solidity-linter-rules/105-payable-fallback-rule-staging branch from 690bb4d to 3892b47 Compare October 8, 2023 21:33
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules-staging branch 2 times, most recently from 03b3702 to ba700c1 Compare October 9, 2023 00:49
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules/105-payable-fallback-rule-staging branch from 34f33c7 to 5ca2832 Compare October 9, 2023 01:52
@0xmemorygrinder 0xmemorygrinder merged commit a66fb83 into feature/50-solidity-linter-rules-staging Oct 9, 2023
6 checks passed
@0xmemorygrinder 0xmemorygrinder deleted the feature/50-solidity-linter-rules/105-payable-fallback-rule-staging branch October 9, 2023 01:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@0xtekgrinder 0xtekgrinder 0xtekgrinder approved these changes

Assignees

@Leon-azerty Leon-azerty

Labels
None yet
Projects
Project Management
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xtekgrinder @0xmemorygrinder @Leon-azerty