This repository has been archived by the owner on Jul 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
101 - No Empty Blocks Rule #148
Merged
0xmemorygrinder
merged 7 commits into
feature/50-solidity-linter-rules-staging
from
feature/50-solidity-linter-rules/101-no-empty-blocks-rule-staging
Oct 9, 2023
Merged
101 - No Empty Blocks Rule #148
0xmemorygrinder
merged 7 commits into
feature/50-solidity-linter-rules-staging
from
feature/50-solidity-linter-rules/101-no-empty-blocks-rule-staging
Oct 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmemorygrinder
force-pushed
the
feature/50-solidity-linter-rules-staging
branch
from
September 30, 2023 17:20
36d6706
to
09fcef1
Compare
0xmemorygrinder
force-pushed
the
feature/50-solidity-linter-rules/101-no-empty-blocks-rule-staging
branch
from
September 30, 2023 17:25
eb92880
to
21d642c
Compare
0xtekgrinder
suggested changes
Oct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use ast instead of parsing with lines.
ps: remove the remove-me file
0xmemorygrinder
force-pushed
the
feature/50-solidity-linter-rules-staging
branch
from
October 3, 2023 15:08
ea96ece
to
9510554
Compare
0xmemorygrinder
force-pushed
the
feature/50-solidity-linter-rules/101-no-empty-blocks-rule-staging
branch
2 times, most recently
from
October 3, 2023 23:53
660abc1
to
303036e
Compare
0xtekgrinder
approved these changes
Oct 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0xmemorygrinder
force-pushed
the
feature/50-solidity-linter-rules-staging
branch
from
October 7, 2023 19:27
662f9c5
to
f3cf5fe
Compare
0xmemorygrinder
force-pushed
the
feature/50-solidity-linter-rules/101-no-empty-blocks-rule-staging
branch
from
October 7, 2023 22:30
8d47c9e
to
7f71f07
Compare
0xSwapFeeder
force-pushed
the
feature/50-solidity-linter-rules/101-no-empty-blocks-rule-staging
branch
from
October 8, 2023 21:36
7f71f07
to
adf2989
Compare
0xmemorygrinder
force-pushed
the
feature/50-solidity-linter-rules-staging
branch
2 times, most recently
from
October 9, 2023 00:49
03b3702
to
ba700c1
Compare
0xmemorygrinder
force-pushed
the
feature/50-solidity-linter-rules/101-no-empty-blocks-rule-staging
branch
from
October 9, 2023 01:01
adf2989
to
ac7657d
Compare
0xmemorygrinder
force-pushed
the
feature/50-solidity-linter-rules/101-no-empty-blocks-rule-staging
branch
from
October 9, 2023 01:15
686fc3b
to
521c7d1
Compare
0xmemorygrinder
merged commit Oct 9, 2023
9d8cc99
into
feature/50-solidity-linter-rules-staging
10 checks passed
0xmemorygrinder
deleted the
feature/50-solidity-linter-rules/101-no-empty-blocks-rule-staging
branch
October 9, 2023 01:19
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #101