Skip to content
This repository has been archived by the owner on Jul 3, 2024. It is now read-only.

Conversation

github-actions[bot]
Copy link

Solves #101

@0xtekgrinder 0xtekgrinder self-requested a review September 29, 2023 19:18
@0xtekgrinder 0xtekgrinder self-assigned this Sep 29, 2023
@0xtekgrinder 0xtekgrinder marked this pull request as ready for review September 29, 2023 19:18
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules-staging branch from 36d6706 to 09fcef1 Compare September 30, 2023 17:20
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules/101-no-empty-blocks-rule-staging branch from eb92880 to 21d642c Compare September 30, 2023 17:25
Copy link
Member

@0xtekgrinder 0xtekgrinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use ast instead of parsing with lines.

ps: remove the remove-me file

@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules-staging branch from ea96ece to 9510554 Compare October 3, 2023 15:08
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules/101-no-empty-blocks-rule-staging branch 2 times, most recently from 660abc1 to 303036e Compare October 3, 2023 23:53
Copy link
Member

@0xtekgrinder 0xtekgrinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules-staging branch from 662f9c5 to f3cf5fe Compare October 7, 2023 19:27
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules/101-no-empty-blocks-rule-staging branch from 8d47c9e to 7f71f07 Compare October 7, 2023 22:30
@0xmemorygrinder 0xmemorygrinder self-assigned this Oct 8, 2023
@0xSwapFeeder 0xSwapFeeder force-pushed the feature/50-solidity-linter-rules/101-no-empty-blocks-rule-staging branch from 7f71f07 to adf2989 Compare October 8, 2023 21:36
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules-staging branch 2 times, most recently from 03b3702 to ba700c1 Compare October 9, 2023 00:49
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules/101-no-empty-blocks-rule-staging branch from adf2989 to ac7657d Compare October 9, 2023 01:01
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules/101-no-empty-blocks-rule-staging branch from 686fc3b to 521c7d1 Compare October 9, 2023 01:15
@0xmemorygrinder 0xmemorygrinder merged commit 9d8cc99 into feature/50-solidity-linter-rules-staging Oct 9, 2023
10 checks passed
@0xmemorygrinder 0xmemorygrinder deleted the feature/50-solidity-linter-rules/101-no-empty-blocks-rule-staging branch October 9, 2023 01:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants