Skip to content
This repository has been archived by the owner on Jul 3, 2024. It is now read-only.

115 - Visibility Modifier Order Rule #153

Merged
merged 4 commits into from
Oct 9, 2023
Merged

115 - Visibility Modifier Order Rule #153

merged 4 commits into from
Oct 9, 2023

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Oct 2, 2023

Solves #115

@Leon-azerty Leon-azerty marked this pull request as ready for review October 2, 2023 14:15
0xmemorygrinder
0xmemorygrinder suggested changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@0xmemorygrinder 0xmemorygrinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your parsing system does not take into account all possible cases
What if the function attributes are at a different line that the function keyword ?
I recommend to use the ast crate to retrieve function ast nodes and call span methods on each attribute

@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules-staging branch from ea96ece to 9510554 Compare October 3, 2023 15:08
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules/115-visibility-modifier-order-rule-staging branch 2 times, most recently from 92580f4 to 3bcf775 Compare October 3, 2023 23:55
@Leon-azerty Leon-azerty self-assigned this Oct 6, 2023
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules-staging branch from 662f9c5 to f3cf5fe Compare October 7, 2023 19:27
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules/115-visibility-modifier-order-rule-staging branch from 173530d to b1ad021 Compare October 7, 2023 22:37
@0xSwapFeeder 0xSwapFeeder force-pushed the feature/50-solidity-linter-rules/115-visibility-modifier-order-rule-staging branch from b1ad021 to 8666dfd Compare October 8, 2023 21:35
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules-staging branch 2 times, most recently from 03b3702 to ba700c1 Compare October 9, 2023 00:49
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules/115-visibility-modifier-order-rule-staging branch from 8666dfd to 952d7ac Compare October 9, 2023 01:59
@0xmemorygrinder 0xmemorygrinder removed the request for review from 0xtekgrinder October 9, 2023 01:59
@0xmemorygrinder 0xmemorygrinder merged commit 54f935d into feature/50-solidity-linter-rules-staging Oct 9, 2023
6 checks passed
@0xmemorygrinder 0xmemorygrinder deleted the feature/50-solidity-linter-rules/115-visibility-modifier-order-rule-staging branch October 9, 2023 02:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@0xmemorygrinder 0xmemorygrinder 0xmemorygrinder approved these changes

Assignees

@0xtekgrinder 0xtekgrinder

Labels
None yet
Projects
Project Management
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xmemorygrinder @0xtekgrinder @Leon-azerty