This repository has been archived by the owner on Jul 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
116 - Foundry Test Functions Rule #166
Merged
0xmemorygrinder
merged 7 commits into
feature/50-solidity-linter-rules-staging
from
feature/50-solidity-linter-rules/116-foundry-test-functions-rule-staging
Oct 9, 2023
Merged
116 - Foundry Test Functions Rule #166
0xmemorygrinder
merged 7 commits into
feature/50-solidity-linter-rules-staging
from
feature/50-solidity-linter-rules/116-foundry-test-functions-rule-staging
Oct 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xtekgrinder
suggested changes
Oct 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactor the rule to only apply public and external functions + apply to .t.sol file only. Need also to have an array of data that can be skipped
0xSwapFeeder
force-pushed
the
feature/50-solidity-linter-rules/116-foundry-test-functions-rule-staging
branch
from
October 8, 2023 21:34
1a07d49
to
c6c7f32
Compare
0xmemorygrinder
force-pushed
the
feature/50-solidity-linter-rules-staging
branch
2 times, most recently
from
October 9, 2023 00:49
03b3702
to
ba700c1
Compare
0xmemorygrinder
force-pushed
the
feature/50-solidity-linter-rules/116-foundry-test-functions-rule-staging
branch
from
October 9, 2023 15:43
c6c7f32
to
0d05957
Compare
0xtekgrinder
suggested changes
Oct 9, 2023
toolchains/solidity/linter/core/solidhunter-lib/testdata/FoundryFunctionName/file.t.sol
Show resolved
Hide resolved
0xmemorygrinder
force-pushed
the
feature/50-solidity-linter-rules/116-foundry-test-functions-rule-staging
branch
from
October 9, 2023 20:10
143bb6e
to
8742a7c
Compare
0xtekgrinder
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0xmemorygrinder
force-pushed
the
feature/50-solidity-linter-rules/116-foundry-test-functions-rule-staging
branch
4 times, most recently
from
October 9, 2023 20:28
83ffc29
to
4699564
Compare
0xmemorygrinder
force-pushed
the
feature/50-solidity-linter-rules-staging
branch
2 times, most recently
from
October 9, 2023 20:36
fe0a5fc
to
cd432d0
Compare
…t-functions-rule-staging
…external functions only
0xmemorygrinder
force-pushed
the
feature/50-solidity-linter-rules/116-foundry-test-functions-rule-staging
branch
from
October 9, 2023 20:36
4699564
to
70fa9b5
Compare
0xmemorygrinder
deleted the
feature/50-solidity-linter-rules/116-foundry-test-functions-rule-staging
branch
October 9, 2023 20:41
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #116