Skip to content
This repository has been archived by the owner on Jul 3, 2024. It is now read-only.

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Oct 7, 2023

Solves #116

@0xmemorygrinder 0xmemorygrinder marked this pull request as ready for review October 8, 2023 19:30
Copy link
Member

@0xtekgrinder 0xtekgrinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor the rule to only apply public and external functions + apply to .t.sol file only. Need also to have an array of data that can be skipped

remove-me-6e6600447ae644d8ace4.txt Outdated Show resolved Hide resolved
@0xSwapFeeder 0xSwapFeeder force-pushed the feature/50-solidity-linter-rules/116-foundry-test-functions-rule-staging branch from 1a07d49 to c6c7f32 Compare October 8, 2023 21:34
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules-staging branch 2 times, most recently from 03b3702 to ba700c1 Compare October 9, 2023 00:49
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules/116-foundry-test-functions-rule-staging branch from c6c7f32 to 0d05957 Compare October 9, 2023 15:43
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules/116-foundry-test-functions-rule-staging branch from 143bb6e to 8742a7c Compare October 9, 2023 20:10
Copy link
Member

@0xtekgrinder 0xtekgrinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules/116-foundry-test-functions-rule-staging branch 4 times, most recently from 83ffc29 to 4699564 Compare October 9, 2023 20:28
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules-staging branch 2 times, most recently from fe0a5fc to cd432d0 Compare October 9, 2023 20:36
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/50-solidity-linter-rules/116-foundry-test-functions-rule-staging branch from 4699564 to 70fa9b5 Compare October 9, 2023 20:36
@0xmemorygrinder 0xmemorygrinder merged commit 37dc7f5 into feature/50-solidity-linter-rules-staging Oct 9, 2023
@0xmemorygrinder 0xmemorygrinder deleted the feature/50-solidity-linter-rules/116-foundry-test-functions-rule-staging branch October 9, 2023 20:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants