Fix OpenLineage deprecation warning #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openlineage suggests using event_v2 as the new import call
UserWarning: {message : DeprecationWarning('This module is deprecated. Please use `openlineage.client.event_v2`.'), category : 'DeprecationWarning', filename : '/home/airflow/.local/lib/python3.10/site-packages/openlineage/client/filter.py', lineno : 9, line : None}
dosubot
bot
added
the
size:XS
✅ Deploy Preview for sunny-pastelito-5ecb04 canceled.
|
dosubot
bot
added
the
area:lineage
pankajastro
reviewed
Jan 13, 2025
tatiana
reviewed
Jan 13, 2025
There was a problem hiding this comment.
This is really helpful, @CorsettiS , thank you very much for pointing this out and submitting a fix. I left some minor feedback in-line
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1449 +/- ##
==========================================
- Coverage 96.94% 96.87% -0.07%
==========================================
Files 73 73
Lines 4355 4358 +3
==========================================
Hits 4222 4222
- Misses 133 136 +3 ☔ View full report in Codecov by Sentry. |
pankajkoti
approved these changes
Jan 17, 2025
tatiana
changed the title
tatiana
approved these changes
Jan 24, 2025
tatiana
changed the title
|
Thanks a lot for taking this to completion, @corsettigyg ! We'll be releasing it as part of Cosmos 1.9.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
openlineage suggests using event_v2 as the new import call. This can be seen in the source code of openlineage itself for the run method.
Related Issue(s)
UserWarning: {message : DeprecationWarning('This module is deprecated. Please use
openlineage.client.event_v2.'), category : 'DeprecationWarning', filename : '/home/airflow/.local/lib/python3.10/site-packages/openlineage/client/filter.py', lineno : 9, line : None}Breaking Change?
No
Checklist