Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing isophote test for scipy 1.15 #1989

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

larrybradley
Copy link
Member

@larrybradley larrybradley commented Jan 3, 2025

With the release of scipy 1.15, an isophote test started raising a warning about "RuntimeWarning: Mean of empty slice.", resulting in the test failing (see https://github.com/astropy/photutils/actions/runs/12601676522/job/35123249287). The test fails only on windows.

The line causing this is

isophote\sample.py:299:
    self.mean = np.mean(s[2])

This PR catches and filters the warning message.

@larrybradley larrybradley force-pushed the fix-test-for-scipy115 branch from 14f4d38 to c30b619 Compare January 3, 2025 22:37
@larrybradley larrybradley force-pushed the fix-test-for-scipy115 branch from c30b619 to 21fbf82 Compare January 3, 2025 22:46
@larrybradley larrybradley merged commit 4e3a845 into astropy:main Jan 3, 2025
23 checks passed
@larrybradley larrybradley deleted the fix-test-for-scipy115 branch January 3, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant