Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change the version from '*' to their original versions #1344

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
+14 −6
Open

fix: change the version from '*' to their original versions #1344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a8c886e
change the version from '*' to their original versions.
ItshMoh Jan 29, 2025
c97344c
minor change
ItshMoh Jan 29, 2025
084e827
Merge branch 'master' into package_version
ItshMoh Jan 29, 2025
ac76ccb
Merge branch 'master' into package_version
derberg Feb 3, 2025
e964268
added the markdown in .changeset directory
ItshMoh Feb 6, 2025
6109a7d
Merge branch 'package_version' of https://github.com/ItshMoh/generato…
ItshMoh Feb 6, 2025
39f5d78
minor changes
ItshMoh Feb 6, 2025
b3a444e
Update .changeset/version.md
ItshMoh Feb 7, 2025
029a7c0
Merge branch 'master' into package_version
ItshMoh Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/version.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
"@asyncapi/generator": patch
---

- Changed the version of `@asyncapi/generator-hooks`, `@asyncapi/generator-components`, `@asyncapi/generator-helpers` and `@asyncapi/nunjucks-filters` from '*' to their original version.

- Replaced asterisk (*) version specifier with explicit version numbers in package dependencies. While the wildcard was intended to resolve packages from local workspaces, it resulted in unnecessary npm registry lookups for unpublished packages. This change ensures proper local workspace resolution and prevents failed registry lookups, improving both reliability and performance.

Comment on lines +5 to +8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😉

Copy link
Author

@ItshMoh ItshMoh Feb 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't get the emoji @derberg. Is it because in the markdown I copypasted the PR description. If yes then this emoji suits this case iykyk

4 changes: 2 additions & 2 deletions apps/generator/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@
"dependencies": {
"@asyncapi/generator-react-sdk": "^1.1.2",
"@asyncapi/multi-parser": "^2.1.1",
"@asyncapi/nunjucks-filters": "*",
"@asyncapi/generator-hooks": "*",
"@asyncapi/nunjucks-filters": "2.2.0",
"@asyncapi/generator-hooks": "0.2.0",
"@asyncapi/parser": "^3.0.14",
"@npmcli/arborist": "5.6.3",
"@npmcli/config": "^8.0.2",
Expand Down
2 changes: 1 addition & 1 deletion apps/generator/test/test-templates/react-template/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@
},
"dependencies": {
"@asyncapi/generator-react-sdk": "^1.1.2",
"@asyncapi/generator-components": "*"
"@asyncapi/generator-components": "1.0.0"
}
}
2 changes: 1 addition & 1 deletion apps/hooks/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@asyncapi/generator-hooks",
"version": "0.1.0",
"version": "0.2.0",
"description": "Library with hooks function for templates using AsyncAPI Generator",
"main": "src/index.js",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion apps/nunjucks-filters/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@asyncapi/nunjucks-filters",
"version": "2.1.0",
"version": "2.2.0",
"description": "Library with Nunjucks filters for templates using AsyncAPI Generator",
"private": false,
"main": "src/index.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/templates/clients/js/websocket/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"license": "Apache-2.0",
"dependencies": {
"@asyncapi/generator-react-sdk": "^1.1.2",
"@asyncapi/generator-helpers": "*",
"@asyncapi/generator-helpers": "1.0.0",
"rimraf": "^3.0.2"
},
"devDependencies": {
Expand Down
Loading