ci: integrate dorny/paths-filter into PR test workflow #1352
Conversation
Fix/skip unnecessary tests
docs: update README.md for testing
Update pr-testing-with-test-project.yml
Update pr-testing-with-test-project.yml
…700/generator into chore/update-ci-workflow
…700/generator into chore/update-ci-workflow
AdityaP700
requested review from
derberg,
magicmatatjahu,
jonaslagoni and
asyncapi-bot-eve
as code owners
|
|
@derberg Hey there, done changes as suggested by you : alternatively worked on adding https://github.com/dorny/paths-filter as i thought it will be more realiable than git inbuilt functionality and hope it would satisfy the branch protection rules. Do let me know if any further change is needed. |
| should_test: ${{ steps.filter.outputs.changes }} | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: dorny/paths-filter@v3 |
There was a problem hiding this comment.
just one thing, for security reasons we always try to remember to not use specific release but commitId
can you switch to something like in the example please: https://github.com/asyncapi/generator/blob/master/.github/workflows/bump.yml#L19
There was a problem hiding this comment.
I get the point now ,alright will do the needful changes as per the suggestions!!
|
|
Hey @derberg ,can you review the PR and let me know of any other thing needs to be done. |
derberg
changed the title
|
/rtm |
Description
dorny/paths-filterinto the PR test workflow.Related issue(s) #1336