fix: remove v2 Spectral schema rules from v3 rules #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoya
requested review from
magicmatatjahu,
jonaslagoni and
asyncapi-bot-eve
as code owners
|
jonaslagoni
approved these changes
Jun 12, 2024
|
/rtm |
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The workflow that validates examples in the Spec repo is failing due to the following reason:
Besides the example is ok or not, that rule should not apply to any v3 document because it is not a valid v3 rule (target paths inside the rule are exclusive for v2). I believe I missed this one when filtering rules for v3 in the past.
This PR filters such a rule to only v2 documents.
Related issue(s)
https://github.com/asyncapi/spec/actions/runs/9481679937/job/26125504690#step:5:46