Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multi-parser)!: force json-path-plus to be ^10.0.7 due to security fixed bug #1086

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

smoya
Copy link
Member

@smoya smoya commented Feb 12, 2025

Copy link

changeset-bot bot commented Feb 12, 2025

🦋 Changeset detected

Latest commit: 79f9930

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@asyncapi/multi-parser Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@smoya smoya changed the title feat!(multi-parser): force json-path-plus to be ^10.0.7 due to security bugfix feat(multi-parser)!: force json-path-plus to be ^10.0.7 due to security bugfix Feb 12, 2025
@smoya smoya changed the title feat(multi-parser)!: force json-path-plus to be ^10.0.7 due to security bugfix feat(multi-parser)!: force json-path-plus to be ^10.0.7 due to security fixed bug Feb 12, 2025
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test is kinda stuck?

@derberg
Copy link
Member

derberg commented Feb 19, 2025

tests on ubunto hang forever, like now I rerun and over 55min running

> test
> turbo run build && turbo run test
Attention:
Turborepo now collects completely anonymous telemetry regarding usage.
This information is used to shape the Turborepo roadmap and prioritize features.
You can learn more, including how to opt-out if you'd not like to participate in this anonymous program, by visiting the following URL:
https://turbo.build/repo/docs/telemetry
• Packages in scope: @asyncapi/multi-parser, @asyncapi/parser
• Running build in 2 packages
• Remote caching disabled
@asyncapi/parser:build
@asyncapi/multi-parser:build
 Tasks:    2 successful, 2 total
Cached:    0 cached, 2 total
  Time:    27.44[6](https://github.com/asyncapi/parser-js/actions/runs/13396915805/job/37462920498?pr=1086#step:10:7)s 
• Packages in scope: @asyncapi/multi-parser, @asyncapi/parser
• Running test in 2 packages
• Remote caching disabled
@asyncapi/parser:build
@asyncapi/multi-parser:test

multi-parser test ran well, just @asyncapi/parser:test did not kick off at all - dunno why

@derberg
Copy link
Member

derberg commented Feb 19, 2025

maybe because of overrides the package-lock file should also be updated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] @asyncapi/multi-parser still depending on vulnerable version of jsonpath-plus
3 participants