Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using Testcontainers for R2DBC MySQL Integration Testing #108 #109

Closed
wants to merge 12 commits into from
Closed

Using Testcontainers for R2DBC MySQL Integration Testing #108 #109

wants to merge 12 commits into from

Conversation

saurabhyadav1985
Copy link
Contributor

@saurabhyadav1985 saurabhyadav1985 commented Apr 24, 2023 •
edited
Loading

Motivation:
To use testcontainers for R2DBC MySQL Integration Testing #76

Modification:

  1. Removing block to start/destroy mysql container from ci-integration-tests.yml
  2. In IntegrationTestSupport adding static block to start mysql container.
  3. Use mapped port of container while building MySqlConnectionConfiguration

Result:
All tests working locally.

@jchrys jchrys self-requested a review April 24, 2023 19:22
jchrys
jchrys reviewed Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@jchrys jchrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for your work!
Just small things.

.github/workflows/ci-integration-tests.yml
@@ -19,13 +19,5 @@ jobs:
distribution: temurin
java-version: 8
cache: maven
- name: Shutdown the Default MySQL
run: sudo service mysql stop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind kindly sharing with us the reason for deleting this line? We appreciate your insights

src/test/java/io/asyncer/r2dbc/mysql/IntegrationTestSupport.java Outdated Show resolved Hide resolved
src/test/java/io/asyncer/r2dbc/mysql/IntegrationTestSupport.java Outdated Show resolved Hide resolved
@jchrys jchrys added this to the 1.0.3 milestone May 30, 2023
@jchrys jchrys removed this from the 1.0.3 / 0.9.4 milestone Sep 19, 2023
@jchrys
Copy link
Collaborator

jchrys commented Apr 2, 2024

close after making coauthored #264 based off of this

@jchrys jchrys closed this Apr 2, 2024
@saurabhyadav1985 saurabhyadav1985 deleted the resolving-merge-conflicts branch April 18, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchrys jchrys jchrys left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saurabhyadav1985 @jchrys @asyncer-io-bot