Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all matroska tags #136

Merged
merged 5 commits into from
Jan 7, 2021
Merged

Add all matroska tags #136

merged 5 commits into from
Jan 7, 2021

Conversation

invliD
Copy link
Contributor

@invliD invliD commented Jan 1, 2021

I found some more tags I need in addition to #135, so I figured I'd just add them all.

@codecov
Copy link

codecov bot commented Jan 1, 2021

Codecov Report

Merging #136 (12285ff) into master (76a505c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #136   +/-   ##
=======================================
  Coverage   99.32%   99.32%           
=======================================
  Files          22       22           
  Lines        1180     1180           
=======================================
  Hits         1172     1172           
  Misses          4        4           
  Partials        4        4           
Impacted Files Coverage Δ
elementtable.go 100.00% <ø> (ø)
elementtype.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76a505c...12285ff. Read the comment docs.

@invliD invliD marked this pull request as ready for review January 1, 2021 23:44
Copy link
Owner

@at-wat at-wat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. It would be better to add comments for deprecated elements.

elementtable.go Show resolved Hide resolved
elementtable.go Show resolved Hide resolved
elementtable.go Show resolved Hide resolved
elementtable.go Show resolved Hide resolved
@invliD
Copy link
Contributor Author

invliD commented Jan 6, 2021

Yeah, I intentionally added the deprecated ones (specifically all those that were included in at least one version of the standard), because I actually have older files that include some of these elements, and they wouldn't be parseable without them defined here. I'll add the comments to those elements.

Copy link
Owner

@at-wat at-wat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@at-wat at-wat merged commit fc0baec into at-wat:master Jan 7, 2021
@invliD invliD deleted the sb/mkv branch January 7, 2021 11:40
@at-wat at-wat mentioned this pull request Feb 15, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants