-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all matroska tags #136
Conversation
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
=======================================
Coverage 99.32% 99.32%
=======================================
Files 22 22
Lines 1180 1180
=======================================
Hits 1172 1172
Misses 4 4
Partials 4 4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me. It would be better to add comments for deprecated elements.
Yeah, I intentionally added the deprecated ones (specifically all those that were included in at least one version of the standard), because I actually have older files that include some of these elements, and they wouldn't be parseable without them defined here. I'll add the comments to those elements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I found some more tags I need in addition to #135, so I figured I'd just add them all.