Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EBML Lacer/Unlacer #140

Merged
merged 7 commits into from
Feb 16, 2021
Merged

Fix EBML Lacer/Unlacer #140

merged 7 commits into from
Feb 16, 2021

Conversation

at-wat
Copy link
Owner

@at-wat at-wat commented Feb 16, 2021

@at-wat at-wat self-assigned this Feb 16, 2021
@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #140 (24f9e00) into master (210ec35) will decrease coverage by 0.28%.
The diff coverage is 97.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
- Coverage   99.32%   99.04%   -0.29%     
==========================================
  Files          22       22              
  Lines        1193     1259      +66     
==========================================
+ Hits         1185     1247      +62     
- Misses          4        6       +2     
- Partials        4        6       +2     
Impacted Files Coverage Δ
lacer.go 93.84% <75.00%> (-2.71%) ⬇️
block.go 100.00% <100.00%> (ø)
elementtable.go 100.00% <100.00%> (ø)
unlacer.go 97.67% <100.00%> (-2.33%) ⬇️
unmarshal.go 98.72% <100.00%> (ø)
value.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 210ec35...24f9e00. Read the comment docs.

Comment on lines +127 to +128
0x43, 0x20, // 800 bytes
0x5E, 0xD3, // 500 bytes
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@at-wat at-wat merged commit 37fac1b into master Feb 16, 2021
@at-wat at-wat deleted the fix-ebml-unlacer branch February 16, 2021 01:44
@at-wat at-wat mentioned this pull request Feb 16, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant