Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-4259 feat: install: export installed package to file, local-install: accept list of package to skip #95

Merged
merged 8 commits into from
Dec 12, 2024

Conversation

tczhao
Copy link
Member

@tczhao tczhao commented Dec 10, 2024

https://atlanhq.atlassian.net/browse/MM-4259

Goal: allows install canary without first reverting to master

Design

Original workflow

  1. install master (packageA:v1, packageB:v1) (include safety check)
  2. install canary(packageA:v1c)
  3. we have (packageA:v1c, packageB:v1)

New Workflow:

  1. safety check
  2. install canary (packageA:v1c) -> output installed list (include installed dependencies) (packageA)
  3. install master (packageB:v1) <- input package to skip install (packageA)
  4. we have (packageA:v1c, packageB:v1)

Changes

safety-check

  • moved out from local-install
  • tested by running safety-check locally
    • script exit successfully
    • use all combination (snapshotInstall * skipVersionCheck), result are as expected

argopm install (installs canary)

  • introduce parameter --export-package-names to export installed packages name to a file
  • tested by unit test, added unit test
  • tested by running argopm to dev cluster
    • all dependency of installed package present in export file
    • script exit successfully
    • package install correctly when empty --export-package-names is provided

local-install

  • accept additional input parameter to skipPackages
  • tested by running script locally to install package on cluster, additional packages skipped
    • script exit successfully
    • package install correctly when empty/none-list skipPackages is provided

@tczhao tczhao changed the title feat: export installed package to file MM-4259 feat: install: export installed package to file, local-install: accept list of package to skip Dec 11, 2024
@tczhao tczhao requested a review from louisnow December 11, 2024 11:59
@tczhao tczhao merged commit e485a0a into master Dec 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants