Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout - response clean up handling #3724

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Timeout - response clean up handling #3724

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ private void traverseEdgesOnDemand(Iterator<AtlasEdge> processEdges, boolean isI
}

private void traverseEdgesOnDemand(AtlasVertex datasetVertex, boolean isInput, int depth, int level, Set<String> visitedVertices, AtlasLineageOnDemandContext atlasLineageOnDemandContext, AtlasLineageOnDemandInfo ret, String baseGuid, AtomicInteger entitiesTraversed, AtomicInteger traversalOrder, TimeoutTracker timeoutTracker) throws AtlasBaseException {
if (isEntityTraversalLimitReached(entitiesTraversed))
if (isEntityTraversalLimitReached(entitiesTraversed) || timeoutTracker.hasTimedOut())
return;
if (depth != 0) { // base condition of recursion for depth
AtlasPerfMetrics.MetricRecorder metricRecorder = RequestContext.get().startMetricRecord("traverseEdgesOnDemand");
Expand Down Expand Up @@ -461,6 +461,10 @@ private void traverseEdgesOnDemand(AtlasVertex datasetVertex, boolean isInput, i
AtlasEntityHeader traversedEntity = ret.getGuidEntityMap().get(AtlasGraphUtilsV2.getIdFromVertex(entityVertex));
if (traversedEntity != null)
traversedEntity.setFinishTime(traversalOrder.get());
if (timeoutTracker.hasTimedOut()) {
ret.setTraversalTimedOut(true);
return;
}
}
}
}
Expand All @@ -471,12 +475,6 @@ private void traverseEdgesOnDemand(AtlasVertex datasetVertex, boolean isInput, i
}


private void executeCircuitBreaker(AtlasEdge atlasEdge, boolean isInput, AtlasLineageOnDemandContext atlasLineageOnDemandContext, AtlasLineageOnDemandInfo ret, int depth, AtomicInteger entitiesTraversed, Set<String> visitedVertices, TimeoutTracker timeoutTracker) {
// Set timeout flags on the entity
handleHorizontalAndVerticalPagination(atlasEdge, !isInput, atlasLineageOnDemandContext, ret, depth, entitiesTraversed, visitedVertices, timeoutTracker);
ret.setTraversalTimedOut(true);
}

private static void setEntityLimitReachedFlag(boolean isInput, AtlasLineageOnDemandInfo ret) {
if (isInput)
ret.setUpstreamEntityLimitReached(true);
Expand Down
Loading